refactor(s2n-quic-dc): reduce the number of peer_addr calls
#2401
+84
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Dec 4, 2024
We do, we just have some checks in place to emulate what unix sockets do when they're closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The current TCP acceptor calls
peer_addrquite a few times, especially after events were added. This change, instead, caches the value and uses that everywhere.Call-outs:
I noticed that our
fmt::Debugimpls were callingpeer_addr().unwrap(), which isn't good. So I refactored those to not panic.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.