fix(s2n-quic-dc): include ipv6 header length in MAX_TOTAL_IPV6 payload length #2727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Description of changes:
We should include a 40 bytes
IPV6_HEADER_LENin the calculation for the max payload size that can be sent for IPV6.I was testing this code on AL2 X86_64 Kernel 5.10 machine, and the max_total_test is consistently failing. I test the limit by changing the constant definition of
MAX_TOTAL_IPV6, and found out that the maximum amount that can be sent with IPV6 isu16::MAX - IPV6_HEADER_LEN - UDP_HEADER_LEN, the current calculation doesn't includeIPV6_HEADER_LEN.Call-outs:
This problem only happens on AL2 X86_64 Kernel 5.10 machine, and we are not aware of any other platforms that will make this fail.
The next step for this PR is to investigate issue #2728.
Testing:
I ran the code on AL2 X86_64 Kernel 5.10 machine, and it succeeded:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.