Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed directory creation to ignore umask, and allow cross process loc… #1078

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

JonathanHenson
Copy link
Contributor

…k to fall back to read only if it can't open the file in rw mode.

testing on this one is hard to automate. Here's how I verified:

create lock directory as user, create lock as user, make sure it works
create lock dir as user, create lock as root, make sure it works for user
create lock dir as root, create lock as root, make sure it works for user
create lock dir as root, try to create lock as user, make sure it works for user.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…k to fall back to read only if it can't open the file in rw mode.
@JonathanHenson JonathanHenson requested a review from a team November 16, 2023 21:26
Copy link

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after tests wrap

source/posix/file.c Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (fefbf4b) 83.40% compared to head (c137a09) 83.30%.

Files Patch % Lines
source/posix/cross_process_lock.c 26.66% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
- Coverage   83.40%   83.30%   -0.11%     
==========================================
  Files          56       56              
  Lines        5792     5804      +12     
==========================================
+ Hits         4831     4835       +4     
- Misses        961      969       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 merged commit 80f21b3 into main Nov 16, 2023
52 checks passed
@waahm7 waahm7 deleted the xproc_lock_fix branch November 16, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants