This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
MessageDecoder can grow and shrink according to usage (in powers of two) #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MessageDecoder
buffer is hard coded to 2MB and will grow to match the size of incoming messages. However, this can result in chronic allocations since the buffer will match the incoming message sizes exactly rather than growing in powers of two.Furthermore, the cache never gets released, so one large message impacts the heap usage forever.
This is especially noticeable on systems that use the eventstream for services such as kinesis, where each lease/shard is allocated its own buffer. It is not long before the size of these buffers becomes a memory bottleneck for the service.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.