-
Notifications
You must be signed in to change notification settings - Fork 379
Add support for Direct Lambda Resolver event format #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I ran Some unrelated changes were suggested outside the scope of this PR, but I did not commit those. Unstaged changes from
|
b527837 to
16106ca
Compare
jlizen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but had some questions.
I see you removed the groups field from AppSyncCognitoIdentity due to semver breakage. If the model needs updating, we can certainly bump the minor version.
But, I don't see the groups field in the docs reference anyway? Do you have more context on it if you'd like to keep it in?
jlizen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I'll get the ball rolling on a new release, will aim for sometime next week.
📬 Issue #, if available:
✍️ Description of changes:
🔏 By submitting this pull request
cargo +nightly fmt.cargo clippy --fix.