chore(integration test stack descriptions): Corrected inaccurate inte…

…g test stack descriptions (#884) * Corrected inaccurate integ test stack descriptions * Update snapshots with new stack descriptions
awslabs · Jan 5, 2023 · 4a499de · 4a499de
1 parent 1981213
commit 4a499de
Show file tree

Hide file tree

Showing 19 changed files with 19 additions and 25 deletions.
diff --git a/.viperlightrc b/.viperlightrc
@@ -1,4 +1,4 @@
 {
  "failOn": "medium",
  "all": true
-}
+}
diff --git a/...aws-solutions-constructs/aws-fargate-dynamodb/test/integ.existing-resources.expected.json b/...aws-solutions-constructs/aws-fargate-dynamodb/test/integ.existing-resources.expected.json
@@ -1,5 +1,5 @@
 {
- "Description": "Integration Test with new VPC, Service and Table",
+ "Description": "Integration Test with existing VPC and Service and Table",
  "Resources": {
  "Vpc8378EB38": {
  "Type": "AWS::EC2::VPC",

diff --git a/.../patterns/@aws-solutions-constructs/aws-fargate-dynamodb/test/integ.existing-resources.ts b/.../patterns/@aws-solutions-constructs/aws-fargate-dynamodb/test/integ.existing-resources.ts
@@ -23,7 +23,7 @@ const app = new App();
 const stack = new Stack(app, generateIntegStackName(__filename), {
  env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
 });
-stack.templateOptions.description = 'Integration Test with new VPC, Service and Table';
+stack.templateOptions.description = 'Integration Test with existing VPC and Service and Table';
 
 const existingVpc = getTestVpc(stack);
 const [ existingTable ] = defaults.buildDynamoDBTable(stack, {});

diff --git a/...-solutions-constructs/aws-fargate-eventbridge/test/integ.existing-resources.expected.json b/...-solutions-constructs/aws-fargate-eventbridge/test/integ.existing-resources.expected.json
@@ -1,5 +1,5 @@
 {
- "Description": "Integration Test with new VPC, Service and Existing Bucket",
+ "Description": "Integration Test with existing VPC, Service and Event Bus",
  "Resources": {
  "Vpc8378EB38": {
  "Type": "AWS::EC2::VPC",

diff --git a/...tterns/@aws-solutions-constructs/aws-fargate-eventbridge/test/integ.existing-resources.ts b/...tterns/@aws-solutions-constructs/aws-fargate-eventbridge/test/integ.existing-resources.ts
@@ -23,7 +23,7 @@ const app = new App();
 const stack = new Stack(app, generateIntegStackName(__filename), {
  env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
 });
-stack.templateOptions.description = 'Integration Test with new VPC, Service and Existing Bucket';
+stack.templateOptions.description = 'Integration Test with existing VPC, Service and Event Bus';
 
 const existingVpc = getTestVpc(stack);
 const image = ecs.ContainerImage.fromRegistry('nginx');

diff --git a/...erns/@aws-solutions-constructs/aws-fargate-s3/test/integ.existing-resources.expected.json b/...erns/@aws-solutions-constructs/aws-fargate-s3/test/integ.existing-resources.expected.json
@@ -1,5 +1,5 @@
 {
- "Description": "Integration Test with new VPC, Service and Bucket",
+ "Description": "Integration Test with existing VPC, Service and Bucket",
  "Resources": {
  "Vpc8378EB38": {
  "Type": "AWS::EC2::VPC",

diff --git a/source/patterns/@aws-solutions-constructs/aws-fargate-s3/test/integ.existing-resources.ts b/source/patterns/@aws-solutions-constructs/aws-fargate-s3/test/integ.existing-resources.ts
@@ -23,7 +23,7 @@ const app = new App();
 const stack = new Stack(app, generateIntegStackName(__filename), {
  env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
 });
-stack.templateOptions.description = 'Integration Test with new VPC, Service and Bucket';
+stack.templateOptions.description = 'Integration Test with existing VPC, Service and Bucket';
 
 const existingVpc = getTestVpc(stack);
 const existingBucket = defaults.CreateScrapBucket(stack, {

diff --git a/...lutions-constructs/aws-fargate-secretsmanager/test/integ.existing-resources.expected.json b/...lutions-constructs/aws-fargate-secretsmanager/test/integ.existing-resources.expected.json
@@ -1,5 +1,5 @@
 {
- "Description": "Integration Test with new VPC, Service and a Secret",
+ "Description": "Integration Test with existing VPC, Service and a Secret",
  "Resources": {
  "Vpc8378EB38": {
  "Type": "AWS::EC2::VPC",

diff --git a/...rns/@aws-solutions-constructs/aws-fargate-secretsmanager/test/integ.existing-resources.ts b/...rns/@aws-solutions-constructs/aws-fargate-secretsmanager/test/integ.existing-resources.ts
@@ -23,7 +23,7 @@ const app = new App();
 const stack = new Stack(app, generateIntegStackName(__filename), {
  env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
 });
-stack.templateOptions.description = 'Integration Test with new VPC, Service and a Secret';
+stack.templateOptions.description = 'Integration Test with existing VPC, Service and a Secret';
 
 const existingVpc = getTestVpc(stack);
 const existingSecretObj = defaults.buildSecretsManagerSecret(stack, 'secret', {});

diff --git a/...rns/@aws-solutions-constructs/aws-fargate-sns/test/integ.existing-resources.expected.json b/...rns/@aws-solutions-constructs/aws-fargate-sns/test/integ.existing-resources.expected.json
@@ -1,5 +1,5 @@
 {
- "Description": "Integration Test with new VPC, Service and Topic",
+ "Description": "Integration Test with existing VPC, Service and Topic",
  "Resources": {
  "Vpc8378EB38": {
  "Type": "AWS::EC2::VPC",

diff --git a/source/patterns/@aws-solutions-constructs/aws-fargate-sns/test/integ.existing-resources.ts b/source/patterns/@aws-solutions-constructs/aws-fargate-sns/test/integ.existing-resources.ts
@@ -23,7 +23,7 @@ const app = new App();
 const stack = new Stack(app, generateIntegStackName(__filename), {
  env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
 });
-stack.templateOptions.description = 'Integration Test with new VPC, Service and Topic';
+stack.templateOptions.description = 'Integration Test with existing VPC, Service and Topic';
 
 const existingVpc = getTestVpc(stack);
 const existingTopic = new sns.Topic(stack, 'test-topic', {});

diff --git a/...rns/@aws-solutions-constructs/aws-fargate-sqs/test/integ.existing-resources.expected.json b/...rns/@aws-solutions-constructs/aws-fargate-sqs/test/integ.existing-resources.expected.json
@@ -1,5 +1,5 @@
 {
- "Description": "Integration Test with new VPC, Service and Queue",
+ "Description": "Integration Test with existing VPC, Service and Queue",
  "Resources": {
  "Vpc8378EB38": {
  "Type": "AWS::EC2::VPC",

diff --git a/source/patterns/@aws-solutions-constructs/aws-fargate-sqs/test/integ.existing-resources.ts b/source/patterns/@aws-solutions-constructs/aws-fargate-sqs/test/integ.existing-resources.ts
@@ -23,7 +23,7 @@ const app = new App();
 const stack = new Stack(app, generateIntegStackName(__filename), {
  env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
 });
-stack.templateOptions.description = 'Integration Test with new VPC, Service and Queue';
+stack.templateOptions.description = 'Integration Test with existing VPC, Service and Queue';
 
 const existingVpc = getTestVpc(stack);
 const existingQueue = new sqs.Queue(stack, 'test-queue', {

diff --git a/...ons-constructs/aws-fargate-ssmstringparameter/test/integ.existing-resources.expected.json b/...ons-constructs/aws-fargate-ssmstringparameter/test/integ.existing-resources.expected.json
@@ -1,5 +1,5 @@
 {
- "Description": "Integration Test with new VPC, Service and SSM String Parameter",
+ "Description": "Integration Test with existing VPC, Service and SSM String Parameter",
  "Resources": {
  "Vpc8378EB38": {
  "Type": "AWS::EC2::VPC",

diff --git a/...@aws-solutions-constructs/aws-fargate-ssmstringparameter/test/integ.existing-resources.ts b/...@aws-solutions-constructs/aws-fargate-ssmstringparameter/test/integ.existing-resources.ts
@@ -23,7 +23,7 @@ const app = new App();
 const stack = new Stack(app, generateIntegStackName(__filename), {
  env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
 });
-stack.templateOptions.description = 'Integration Test with new VPC, Service and SSM String Parameter';
+stack.templateOptions.description = 'Integration Test with existing VPC, Service and SSM String Parameter';
 
 const existingVpc = getTestVpc(stack);
 const existingStringParameterObj = new ssm.StringParameter(stack, 'Parameter', {

diff --git a/...utions-constructs/aws-fargate-stepfunctions/test/integ.no-cloudwatch-alarms.expected.json b/...utions-constructs/aws-fargate-stepfunctions/test/integ.no-cloudwatch-alarms.expected.json
@@ -1,5 +1,5 @@
 {
- "Description": "Integration Test with new VPC, Service and a state machine with no CloudWatch alarms",
+ "Description": "Integration Test with existing VPC and Service and a new state machine with no CloudWatch alarms",
  "Resources": {
  "Vpc8378EB38": {
  "Type": "AWS::EC2::VPC",

diff --git a/...ns/@aws-solutions-constructs/aws-fargate-stepfunctions/test/integ.no-cloudwatch-alarms.ts b/...ns/@aws-solutions-constructs/aws-fargate-stepfunctions/test/integ.no-cloudwatch-alarms.ts
@@ -23,7 +23,7 @@ const app = new App();
 const stack = new Stack(app, defaults.generateIntegStackName(__filename), {
  env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
 });
-stack.templateOptions.description = 'Integration Test with new VPC, Service and a state machine with no CloudWatch alarms';
+stack.templateOptions.description = 'Integration Test with existing VPC and Service and a new state machine with no CloudWatch alarms';
 
 const existingVpc = defaults.getTestVpc(stack);
 const startState = new stepfunctions.Pass(stack, 'StartState');

diff --git a/...ons-constructs/aws-lambda-elasticachememcached/test/integ.existingResources.expected.json b/...ons-constructs/aws-lambda-elasticachememcached/test/integ.existingResources.expected.json
@@ -1,5 +1,5 @@
 {
- "Description": "Integration Test with new resourcesfor aws-lambda-elasticachememcached",
+ "Description": "Integration Test with existing vpc, Lambda function and cache",
  "Resources": {
  "Vpc8378EB38": {
  "Type": "AWS::EC2::VPC",

diff --git a/...@aws-solutions-constructs/aws-lambda-elasticachememcached/test/integ.existingResources.ts b/...@aws-solutions-constructs/aws-lambda-elasticachememcached/test/integ.existingResources.ts
@@ -21,16 +21,10 @@ import { generateIntegStackName, getTestVpc, CreateTestCache, addCfnSuppressRule
 // Setup
 const app = new App();
 const stack = new Stack(app, generateIntegStackName(__filename));
-stack.templateOptions.description = 'Integration Test with new resourcesfor aws-lambda-elasticachememcached';
+stack.templateOptions.description = 'Integration Test with existing vpc, Lambda function and cache';
 
 const testVpc = getTestVpc(stack, false);
 
-// const testSG = new ec2.SecurityGroup(stack, 'test-sg', {
-// vpc: testVpc,
-// });
-// addCfnSuppressRules(testSG, [{ id: "W40", reason: "Test Resource" }]);
-// addCfnSuppressRules(testSG, [{ id: "W5", reason: "Test Resource" }]);
-// addCfnSuppressRules(testSG, [{ id: "W36", reason: "Test Resource" }]);
 const testSG = buildSecurityGroup(stack, 'test-sg', { vpc: testVpc }, [], []);
 
 const testFunction = new lambda.Function(stack, 'test-function', {