chore(all): remove vestiges of v1 support #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biffgaut
requested review from
hayesry,
mobri2a,
emcfins,
mickychetta and
georgebearden
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
georgebearden
approved these changes
Jan 29, 2024
| @@ -27,10 +27,13 @@ | |||
| "jsii-pacmak": "^1.92.0", | |||
| "tslint": "^5.20.1", | |||
| "typescript": "4.7.4", | |||
| "aws-cdk-migration": "^1.135.0" | |||
| "aws-cdk-migration": "^1.135.0", | |||
| "constructs": "10.0.0" | |||
There was a problem hiding this comment.
pinning constructs to 10.0.0 explicitly, without allowing for minor or patch upgrades seems intentional, so just curious about the reasoning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There are still scripts left from when we supported V1 and V2 simultaneously, and some scripts made more complex for that support. V1 is long since deprecated, we can remove this support and simplify our scripts.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.