Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-eventbridge-lambdba): handle provided role correctly #1063

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

biffgaut
Copy link
Contributor

Description of changes:
If the client provides a role without a default policy, we need to ensure we don't try to add cfn_nag suppression to the non-existent policy.

This applies to all Lambda based constructs.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 73a5d8f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@biffgaut biffgaut merged commit f5d2403 into main Jan 30, 2024
8 checks passed
@biffgaut biffgaut deleted the ProvidedRoleBug branch January 30, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants