Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packages #3092

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: packages #3092

merged 1 commit into from
Dec 10, 2024

Conversation

tracy-french
Copy link
Contributor

@tracy-french tracy-french commented Dec 9, 2024

Overview

This change improves iot-app-kit with the following changes:

  • Enable development of "protected" packages which public packages may consume, yet aren't released as a public package. The protected package is "public" as it will be in a consumer's node_modules, yet it will not be published to npm. Only iot-app-kit packages may consume public packages. It's like OOP, I think! Plenty of in code docs added.
  • Live development across packages without builds. Run npm start to open the dashboard storybook env and that's it. Run the unit tests, lint, whatever, without building. Start watch mode on vitest for one package, change a dependency of the package, and watch the unit test runner restart. See types changes instantly between files in other packages before you even press save. Is it magic? Yes! The incantations are filled with marginalia.
  • Migration from tsc to Vite for building packages.
  • Improved clean and pack scripts/utils.

Also included:

  • Fix for scene-composer's internationalization. IDs are now correctly injected into the dist.

Legal

This project is available under the Apache 2.0 License.

@tracy-french tracy-french force-pushed the fix-internal-packages-2 branch 16 times, most recently from a4935f3 to 76e0fa1 Compare December 10, 2024 00:32
@tracy-french tracy-french force-pushed the fix-internal-packages-2 branch from 76e0fa1 to 2d44d0c Compare December 10, 2024 03:07
@tracy-french tracy-french marked this pull request as ready for review December 10, 2024 03:17
@tracy-french tracy-french changed the title fix: internal packages fix: packages Dec 10, 2024
Copy link
Contributor

@chejimmy chejimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a great utility to organize AppKit repo packages and TY for fixing some bugs 🍾
Can you add a lil guide/README on how to make an "protected" package? It will help the next person to utilize it 🙏

@tracy-french tracy-french merged commit 3baeafc into rc Dec 10, 2024
25 checks passed
@tracy-french tracy-french deleted the fix-internal-packages-2 branch December 10, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants