-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET submits invalid Complete callback request #285
Labels
Comments
RomainMuller
added
bug
This issue is a bug.
language/dotnet
Related to .NET bindings (C#, F#, ...)
labels
Oct 29, 2018
I have a fix for this. I'm trying to figure out why the existing compliance tests didn't break with this error (throwing from a callback is part of the tested behavior) |
RomainMuller
added a commit
that referenced
this issue
Oct 30, 2018
The response for a callback completion that resulted in an error should use the `err` field name and not the `error` field name as was initially done. Additionally, the program flow did not propagate all errors back to the `jsii-kernel`, causing false-pass on the compliance test suite, as expectations were incorrectly set up to expect `RuntimeException` instead of `JsiiException`. Fixes #285
RomainMuller
added a commit
that referenced
this issue
Oct 30, 2018
The response for a callback completion that resulted in an error should use the `err` field name and not the `error` field name as was initially done. Additionally, the program flow did not propagate all errors back to the `jsii-kernel`, causing false-pass on the compliance test suite, as expectations were incorrectly set up to expect `RuntimeException` instead of `JsiiException`. Fixes #285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
When submitting
Complete
requests, the.NET
runtime emitserror
instead oferr
for failures. This causes the kernel to assume success with undefined value.Discovered as part of aws/aws-cdk#1027
The text was updated successfully, but these errors were encountered: