Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of private API use #350

Closed
rix0rrr opened this issue Feb 1, 2019 · 0 comments · Fixed by #352
Closed

Get rid of private API use #350

rix0rrr opened this issue Feb 1, 2019 · 0 comments · Fixed by #352

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Feb 1, 2019

To parse tsconfig.json, the compiler needs a ParseConfigHost, which contains functions to inspect the filesystem. Unlike a CompilerHost, there is no public factory function to create one.

There is a private function to turn an existing CompilerHost into a ParseConfigHost which we call today, but we've gotten some signal that this function may be removed in an upcoming version, so we're going to have to implement our own ParseConfigHost soon.

https://github.com/awslabs/jsii/blob/4ecf28ceaaf130bd1622765468bc64a43fbb5efd/packages/jsii/lib/compiler.ts#L262

rix0rrr pushed a commit that referenced this issue Feb 1, 2019
Until we can properly tackle #350, freeze the version of the
TypeScript compiler to a known-good version right now.
rix0rrr added a commit that referenced this issue Feb 1, 2019
Don't use the upstream private API function to turn a `CompilerHost` into a
`ParseConfigHost` anymore; instead, I copied the implementation, which is
simple enough.

Fixes #350.
RomainMuller added a commit that referenced this issue Feb 4, 2019
### Bug Fixes
* remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350)
* **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341)
* **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401))
* **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345)

### Features
* **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c))
* Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
@RomainMuller RomainMuller mentioned this issue Feb 4, 2019
RomainMuller added a commit that referenced this issue Feb 4, 2019
### Bug Fixes
* remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350)
* **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341)
* **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401))
* **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345)

### Features
* **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c))
* Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant