Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii-pacmack): default to target directory mode #363

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 14, 2019

Always generate to $root/dist/TARGET, even when only
generating one target. This behavior works better
for selectively building targets in a larger build that
expects certain naming conventions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Always generate to `$root/dist/TARGET`, even when only
generating one target. This behavior works better
for selectively building targets in a larger build that
expects certain naming conventions.
@rix0rrr rix0rrr requested a review from a team as a code owner February 14, 2019 11:16
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure something will break but have no idea how to test

@rix0rrr rix0rrr merged commit 967d917 into master Feb 14, 2019
@rix0rrr rix0rrr deleted the huijbers/pacmak-dirs branch February 14, 2019 15:34
RomainMuller added a commit that referenced this pull request Feb 27, 2019
### Bug Fixes

* **jsii-pacmack:** default to target directory mode ([#363](#363)) ([967d917](967d917))
* **java-runtime:** Bump version of Jackson because of CVEs ([#362](#362)) ([140aa4d](140aa4d))
* **jsii:** detect double interface member declarations ([#360](#360)) ([b2b2c89](b2b2c89)), closes [#340](#340)
RomainMuller added a commit that referenced this pull request Feb 27, 2019
### Bug Fixes

* **jsii-pacmack:** default to target directory mode ([#363](#363)) ([967d917](967d917))
* **java-runtime:** Bump version of Jackson because of CVEs ([#362](#362)) ([140aa4d](140aa4d))
* **jsii:** detect double interface member declarations ([#360](#360)) ([b2b2c89](b2b2c89)), closes [#340](#340)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants