fix(kernel): make type serialization explicit and recursive #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialize and deserialize types according to their declared static type, and add validation on the runtime types matching the declared types. This is in contrast to previously, when we mostly only used the runtime types to determine what to do, and harly any validation was done. The runtime types used to be able to freely disagree with the declared types, and we put a lot of burden on the JSII runtimes at the other end of the wire. Fix tests that used to exercise the API with invalid arguments. Remove Proxy objects since they only existed to prevent accidentally overwriting certain keys via the jsii interface, and Symbols serve the same purpose (but simpler). Fixes aws/aws-cdk#1981.
RomainMuller
approved these changes
Mar 27, 2019
eladb
approved these changes
Mar 27, 2019
| * | ||
| * Types will be serialized according to the following table: | ||
| * | ||
| * ┬───────────────────────────────────────────────────────────────────────────────────────────────┐ |
| // ---------------------------------------------------------------------- | ||
| [SerializationClass.Enum]: { | ||
| serialize(value, type, host): WireEnum | undefined { | ||
| host.debug('hullo'); |
There was a problem hiding this comment.
remove (not really important).
| }, | ||
|
|
||
| // ---------------------------------------------------------------------- | ||
| [SerializationClass.Struct]: { |
| // This looks odd, but if an object was originally passed in as a by-ref | ||
| // class, and it happens to conform to a datatype interface we say we're | ||
| // returning, return the actual object instead of the serialized value. | ||
| // NOTE: Not entirely sure yet whether this is a bug masquerading as a |
There was a problem hiding this comment.
I think it's okay for the kernel to allow passing in structs by reference. It should Just Work I guess
There was a problem hiding this comment.
Yeah I think it can be backwards-compatible.
added 2 commits
March 28, 2019 08:09
RomainMuller
added a commit
that referenced
this pull request
Mar 28, 2019
RomainMuller
added a commit
that referenced
this pull request
Mar 28, 2019
Merged
RomainMuller
added a commit
that referenced
this pull request
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize and deserialize types according to their declared static type,
and add validation on the runtime types matching the declared types.
This is in contrast to previously, when we mostly only used the runtime
types to determine what to do, and hardly any validation was done. The
runtime types used to be able to freely disagree with the declared
types, and we put a lot of burden on the JSII runtimes at the other
end of the wire.
Fix tests that used to exercise the API with invalid arguments.
Remove Proxy objects since they only existed to prevent accidentally
overwriting certain keys via the jsii interface, and Symbols serve
the same purpose (but simpler).
Fixes aws/aws-cdk#1981.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.