Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe name fix in auto setup script for internal scheme ALBs #732

Merged
merged 2 commits into from
May 10, 2023
Merged

Describe name fix in auto setup script for internal scheme ALBs #732

merged 2 commits into from
May 10, 2023

Conversation

rrrkharse
Copy link
Contributor

@rrrkharse rrrkharse commented May 10, 2023 •
edited
Loading

Which issue is resolved by this Pull Request:
Resolves #552

Description of your changes:
Currently the ALB name is extracted from the ALB DNS. For internal scheme ALBs the DNS contains a internal- prefix that is not part of the ALB name.

Screen Shot 2023-05-10 at 2 08 12 PM

The changes in this PR strip internal- from the front of the DNS name. ALB validation prevents ALBs with internal- as a prefix from being created.

Testing:

Tested auto setup script:

ubuntu@ip-172-31-21-105:~/kfdistro/internal-lb-name/kubeflow-manifests/tests/e2e$ PYTHONPATH=.. python utils/load_balancer/setup_load_balancer.py
=================================================================
                          Reading Config
=================================================================
=================================================================
                  Creating Subdomain in Route 53
=================================================================
INFO:botocore.credentials:Found credentials in shared credentials file: ~/.aws/credentials
INFO:e2e.utils.aws.route53:created hosted zone internallb.rkharse.people.aws.dev with id Z00017732SEX83VY6HBBP
INFO:e2e.utils.aws.route53:waiting for for change id: C00290083SGKI7MGQMU9J to be IN_SYNC in hosted zone: Z09881373FTWJWBP0QN22, domain: rkharse.people.aws.dev
=================================================================
                   Creating Certificate in ACM
=================================================================
INFO:e2e.utils.aws.acm:requested DNS validation for domain *.rkharse.people.aws.dev.                 certificate ARN is arn:aws:acm:us-west-2:556017915589:certificate/f7447c75-
2e88-4cd9-a0bf-2c5633f20848.
INFO:e2e.utils.aws.acm:arn:aws:acm:us-west-2:556017915589:certificate/f7447c75-2e88-4cd9-a0bf-2c5633f20848: waiting for domain validation record ...
INFO:e2e.utils.aws.route53:waiting for for change id: C0167757FA3S1JHWEKFT to be IN_SYNC in hosted zone: Z09881373FTWJWBP0QN22, domain: rkharse.people.aws.dev
INFO:e2e.utils.aws.acm:arn:aws:acm:us-west-2:556017915589:certificate/f7447c75-2e88-4cd9-a0bf-2c5633f20848: waiting for validation ...
INFO:e2e.utils.aws.acm:requested DNS validation for domain *.internallb.rkharse.people.aws.dev.                 certificate ARN is arn:aws:acm:us-west-2:556017915589:certificat
e/52ae7c85-d7ac-466e-9e38-c2f70994d634.
INFO:e2e.utils.aws.acm:arn:aws:acm:us-west-2:556017915589:certificate/52ae7c85-d7ac-466e-9e38-c2f70994d634: waiting for domain validation record ...
INFO:e2e.utils.aws.route53:waiting for for change id: C06197623SXTC35K87BBZ to be IN_SYNC in hosted zone: Z00017732SEX83VY6HBBP, domain: internallb.rkharse.people.aws.dev
INFO:e2e.utils.aws.acm:arn:aws:acm:us-west-2:556017915589:certificate/52ae7c85-d7ac-466e-9e38-c2f70994d634: waiting for validation ...
=================================================================
    Configuring Ingress and load balancer controller manifests
=================================================================
2023-05-10 20:46:43 [ℹ]  IAM Open ID Connect provider is already associated with cluster "internal-lb-name" in "us-west-2"
INFO:e2e.utils.aws.iam:created iam policy arn:aws:iam::556017915589:policy/alb_ingress_controller_internal-lb-namefzw5ugcgzo.
2023-05-10 20:46:45 [ℹ]  3 existing iamserviceaccount(s) (kube-system/aws-load-balancer-controller,kube-system/aws-node,kube-system/ebs-csi-controller-sa) will be excluded
2023-05-10 20:46:45 [ℹ]  1 iamserviceaccount (kube-system/aws-load-balancer-controller) was excluded (based on the include/exclude rules)
2023-05-10 20:46:45 [!]  metadata of serviceaccounts that exist in Kubernetes will be updated, as --override-existing-serviceaccounts was set
2023-05-10 20:46:45 [ℹ]  no tasks
=================================================================
Creating Ingress, load balancer and updating the domain's DNS record
=================================================================
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
2023/05/10 20:46:45 well-defined vars that were never replaced: clusterName
customresourcedefinition.apiextensions.k8s.io/ingressclassparams.elbv2.k8s.aws unchanged
customresourcedefinition.apiextensions.k8s.io/targetgroupbindings.elbv2.k8s.aws unchanged
serviceaccount/aws-load-balancer-controller unchanged
role.rbac.authorization.k8s.io/aws-load-balancer-controller-leader-election-role unchanged
clusterrole.rbac.authorization.k8s.io/aws-load-balancer-controller-role configured
rolebinding.rbac.authorization.k8s.io/aws-load-balancer-controller-leader-election-rolebinding unchanged
clusterrolebinding.rbac.authorization.k8s.io/aws-load-balancer-controller-rolebinding unchanged
configmap/istio-ingress-parameters unchanged
configmap/aws-load-balancer-controller-config unchanged
service/aws-load-balancer-webhook-service unchanged
deployment.apps/aws-load-balancer-controller unchanged
certificate.cert-manager.io/aws-load-balancer-serving-cert unchanged
issuer.cert-manager.io/aws-load-balancer-selfsigned-issuer unchanged
ingress.networking.k8s.io/istio-ingress unchanged
mutatingwebhookconfiguration.admissionregistration.k8s.io/aws-load-balancer-webhook configured
validatingwebhookconfiguration.admissionregistration.k8s.io/aws-load-balancer-webhook configured
running command: ['kubectl', 'wait', '--for', 'condition=established', '--timeout=60s', 'crd/ingressclassparams.elbv2.k8s.aws']
customresourcedefinition.apiextensions.k8s.io/ingressclassparams.elbv2.k8s.aws condition met
customresourcedefinition.apiextensions.k8s.io/ingressclassparams.elbv2.k8s.aws unchanged
customresourcedefinition.apiextensions.k8s.io/targetgroupbindings.elbv2.k8s.aws unchanged
serviceaccount/aws-load-balancer-controller unchanged
role.rbac.authorization.k8s.io/aws-load-balancer-controller-leader-election-role unchanged
clusterrole.rbac.authorization.k8s.io/aws-load-balancer-controller-role configured
rolebinding.rbac.authorization.k8s.io/aws-load-balancer-controller-leader-election-rolebinding unchanged
clusterrolebinding.rbac.authorization.k8s.io/aws-load-balancer-controller-rolebinding unchanged
configmap/istio-ingress-parameters unchanged
configmap/aws-load-balancer-controller-config unchanged
service/aws-load-balancer-webhook-service unchanged
deployment.apps/aws-load-balancer-controller unchanged
certificate.cert-manager.io/aws-load-balancer-serving-cert unchanged
issuer.cert-manager.io/aws-load-balancer-selfsigned-issuer unchanged
ingress.networking.k8s.io/istio-ingress unchanged
mutatingwebhookconfiguration.admissionregistration.k8s.io/aws-load-balancer-webhook configured
validatingwebhookconfiguration.admissionregistration.k8s.io/aws-load-balancer-webhook configured
INFO:__main__:waiting for ALB creation ...
INFO:__main__: internal-k8s-istiosys-istioing-a54524e5ec-369534536.us-west-2.elb.amazonaws.com waiting for ALB status = active ...
INFO:e2e.utils.aws.route53:waiting for for change id: C1000779Z3PLM25PI2F7 to be IN_SYNC in hosted zone: Z00017732SEX83VY6HBBP, domain: internallb.rkharse.people.aws.dev

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rrrkharse rrrkharse requested a review from surajkota May 10, 2023 20:58
@rrrkharse rrrkharse merged commit 3958a61 into awslabs:main May 10, 2023
rrrkharse added a commit to rrrkharse/kubeflow-manifests that referenced this pull request May 11, 2023
@rrrkharse
Describe name fix in auto setup script for internal scheme ALBs (awsl…
0fe0d65 
…abs#732)

Currently the ALB name is extracted from the ALB DNS. For internal
scheme ALBs the DNS contains a `internal-` prefix that is not part of
the ALB name.

The changes in this PR strip `internal-` from the front of the DNS name.
ALB validation prevents ALBs with `internal-` as a prefix from being
created.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@rrrkharse rrrkharse mentioned this pull request May 11, 2023
Merged
surajkota pushed a commit that referenced this pull request May 11, 2023
@rrrkharse
[Cherry-pick] Blueprints v4.31.0 (#731) and auto setup describe ALB n…
aa8b07f 
…ame fix (#732)  (#734)

Cherry-pick #731 #732 
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
jsitu777 pushed a commit to jsitu777/kubeflow-manifests that referenced this pull request Jun 27, 2023
@rrrkharse @jsitu777
Describe name fix in auto setup script for internal scheme ALBs (awsl…
6005656 
…abs#732)

Currently the ALB name is extracted from the ALB DNS. For internal
scheme ALBs the DNS contains a `internal-` prefix that is not part of
the ALB name.

The changes in this PR strip `internal-` from the front of the DNS name.
ALB validation prevents ALBs with `internal-` as a prefix from being
created.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajkota surajkota surajkota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated script for load balancer hits LB name length error
2 participants
@rrrkharse @surajkota