Add retry to reading /proc/mounts
#234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Carl Jones <danny@danielcarl.info>
dannycjones
previously approved these changes
Jul 29, 2024
vladem
previously approved these changes
Jul 30, 2024
dannycjones
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we find the root cause of why reading
/proc/mountson newly spawned Karpenter/GPU nodes fails, we're adding retry mechanism to reading/proc/mountsas people reported that reading/proc/mountsworks after retries. See #174This originally contributed by @Shellmode, but since our CI is not properly set up yet, the original PR didn't triggered the CI. This PR is from a branch, and it should properly trigger the CI.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.