Upgrade MP and adding tests for S3 Express #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlakhaws
force-pushed
the
dl-express-testing
branch
5 times, most recently
from
17898e0 to
be66e1c
Compare
dlakhaws
changed the title
dlakhaws
force-pushed
the
dl-express-testing
branch
8 times, most recently
from
7546a01 to
dc41d5d
Compare
jjkr
previously approved these changes
Dec 1, 2023
| // assume us-east-1 since that's where our integration tests currently do their work | ||
| // https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-express-networking.html | ||
| regionAz := "use1-az4" | ||
| if BucketRegion == "us-west-2" { |
There was a problem hiding this comment.
I'm guessing this won't work for regions that aren't us-east-1 or us-west-2? We should at least track a task that will fix this for other regions.
There was a problem hiding this comment.
yea I actually took a brief look into this but there's no programmatic way to see where S3 Express is supported, and right now the only NA regions it supports is us-east-1 and us-west-2, but agreed something to look into in the future
| @@ -61,7 +61,7 @@ jobs: | |||
| needs: build | |||
| strategy: | |||
| matrix: | |||
| cluster-type: ["kops", "eksctl"] | |||
| cluster-type: ["eksctl", "kops"] | |||
There was a problem hiding this comment.
unintentional, I had removed it in a previous commit to test kops only and then added it back in but in reverse order
dlakhaws
force-pushed
the
dl-express-testing
branch
from
dc41d5d to
4288410
Compare
jjkr
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.