Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option --profile for a specific profile in the AWS credentials file #151

Closed
bingzhang00 opened this issue Mar 15, 2023 · 2 comments
Closed

Add option --profile for a specific profile in the AWS credentials file #151

bingzhang00 opened this issue Mar 15, 2023 · 2 comments
Assignees
@eslrahc-swa
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Write and Delete ...

Comments

@bingzhang00
Copy link

Tell us more about this new feature.

It would be nice if we can have an option --profile, like in other AWS command-line tools, so that we can choose a specific profile to use from ~/.aws/credentials. Right now it seems the only way to select a different profile is via environment variables, which is also not documented.

Current behavior

./target/release/mount-s3 --profile
error: Found argument '--profile' which wasn't expected, or isn't valid in this context

        If you tried to supply `--profile` as a value rather than a flag, use `-- --profile`
@bingzhang00 bingzhang00 added the enhancement New feature or request label Mar 15, 2023
@jamesbornholt
Copy link
Member

Thanks! We'll definitely add this. In the meantime, I'll update the documentation so at least it's clear that you can use the AWS_PROFILE environment variable to select a profile.

@jamesbornholt jamesbornholt added this to the Beta (Write support) milestone Mar 15, 2023
@jamesbornholt jamesbornholt mentioned this issue Mar 15, 2023
Merged
@dannycjones dannycjones added the good first issue Good for newcomers label Mar 17, 2023
This was referenced Apr 11, 2023
Closed
Merged
@eslrahc-swa eslrahc-swa mentioned this issue Apr 14, 2023
Merged
@dannycjones dannycjones mentioned this issue Apr 14, 2023
Closed
jamesbornholt added a commit that referenced this issue Apr 20, 2023
@eslrahc-swa @jamesbornholt
Add support for AWS profile and unsigned requests as command line arg…
0f3b980 
…uments (#209)

* Add supports for AWS profile and unsigned requests.

Supports profile and unsigned requests with the following:

* Add option --profile for a specific profile in the AWS credentials file #151
* Add support for unsigned requests #181

This commit also includes changes that rust defined signing_config owns a
credentials_provider so it can live as long as signing_conig.

Signed-off-by: Charles Zhang <zyaoshen@amazon.com>

* Add header for no-sign-request help

Signed-off-by: James Bornholt <bornholt@amazon.com>

---------

Signed-off-by: Charles Zhang <zyaoshen@amazon.com>
Signed-off-by: James Bornholt <bornholt@amazon.com>
Co-authored-by: Charles Zhang <zyaoshen@amazon.com>
Co-authored-by: James Bornholt <bornholt@amazon.com>
@ooboyle-rs10
Copy link

Latest version has --profile and work well for me. Thank you.

sauraank pushed a commit to sauraank/mountpoint-s3 that referenced this issue Apr 27, 2023
@eslrahc-swa @jamesbornholt
Add support for AWS profile and unsigned requests as command line arg…
5acb11b 
…uments (awslabs#209)

* Add supports for AWS profile and unsigned requests.

Supports profile and unsigned requests with the following:

* Add option --profile for a specific profile in the AWS credentials file awslabs#151
* Add support for unsigned requests awslabs#181

This commit also includes changes that rust defined signing_config owns a
credentials_provider so it can live as long as signing_conig.

Signed-off-by: Charles Zhang <zyaoshen@amazon.com>

* Add header for no-sign-request help

Signed-off-by: James Bornholt <bornholt@amazon.com>

---------

Signed-off-by: Charles Zhang <zyaoshen@amazon.com>
Signed-off-by: James Bornholt <bornholt@amazon.com>
Co-authored-by: Charles Zhang <zyaoshen@amazon.com>
Co-authored-by: James Bornholt <bornholt@amazon.com>
Signed-off-by: sauraank <sauraank@amazon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eslrahc-swa eslrahc-swa

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Write and Delete support
Development

No branches or pull requests
5 participants
@jamesbornholt @dannycjones @bingzhang00 @eslrahc-swa @ooboyle-rs10