Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unsigned requests #181

Closed
pschmied opened this issue Mar 27, 2023 · 2 comments
Closed

Add support for unsigned requests #181

pschmied opened this issue Mar 27, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@pschmied
Copy link

Tell us more about this new feature.

Allowing for unsigned requests would allow Mountpoint to work as a client for public, world-readable S3 buckets. This would function similarly to the AWS CLI's --no-sign-request flag (e.g. https://awscli.amazonaws.com/v2/documentation/api/latest/reference/s3/ls.html).

@pschmied pschmied added the enhancement New feature or request label Mar 27, 2023
@monthonk
Copy link
Contributor

Thanks for your feedback! It would definitely be nice to have this feature. We will look into it.

jamesbornholt added a commit that referenced this issue Apr 20, 2023
…uments (#209)

* Add supports for AWS profile and unsigned requests.

Supports profile and unsigned requests with the following:

* Add option --profile for a specific profile in the AWS credentials file #151
* Add support for unsigned requests #181

This commit also includes changes that rust defined signing_config owns a
credentials_provider so it can live as long as signing_conig.

Signed-off-by: Charles Zhang <zyaoshen@amazon.com>

* Add header for no-sign-request help

Signed-off-by: James Bornholt <bornholt@amazon.com>

---------

Signed-off-by: Charles Zhang <zyaoshen@amazon.com>
Signed-off-by: James Bornholt <bornholt@amazon.com>
Co-authored-by: Charles Zhang <zyaoshen@amazon.com>
Co-authored-by: James Bornholt <bornholt@amazon.com>
@jamesbornholt
Copy link
Member

Done in #209.

sauraank pushed a commit to sauraank/mountpoint-s3 that referenced this issue Apr 27, 2023
…uments (awslabs#209)

* Add supports for AWS profile and unsigned requests.

Supports profile and unsigned requests with the following:

* Add option --profile for a specific profile in the AWS credentials file awslabs#151
* Add support for unsigned requests awslabs#181

This commit also includes changes that rust defined signing_config owns a
credentials_provider so it can live as long as signing_conig.

Signed-off-by: Charles Zhang <zyaoshen@amazon.com>

* Add header for no-sign-request help

Signed-off-by: James Bornholt <bornholt@amazon.com>

---------

Signed-off-by: Charles Zhang <zyaoshen@amazon.com>
Signed-off-by: James Bornholt <bornholt@amazon.com>
Co-authored-by: Charles Zhang <zyaoshen@amazon.com>
Co-authored-by: James Bornholt <bornholt@amazon.com>
Signed-off-by: sauraank <sauraank@amazon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants