From 08be72edeb3c842d711adbef09e5f1f214b168ee Mon Sep 17 00:00:00 2001 From: NihalHarish Date: Fri, 31 Jul 2020 04:42:13 -0700 Subject: [PATCH 1/2] change enum --- smdebug/tensorflow/keras.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/smdebug/tensorflow/keras.py b/smdebug/tensorflow/keras.py index d30359253..5cf570d6a 100644 --- a/smdebug/tensorflow/keras.py +++ b/smdebug/tensorflow/keras.py @@ -986,7 +986,7 @@ def save_tape_logs(self, model_inputs=None, outputs=None): :param outputs: :return: """ - logs = {ModelOutput.Y: outputs, ModelInput.X: model_inputs} + logs = {ModelOutput.Y_PRED: outputs, ModelInput.X: model_inputs} self.save_smdebug_logs(logs) def wrap_tape(self, tape): From de99fd6fe6dbb9a8bf63ede5aee78a939717c77f Mon Sep 17 00:00:00 2001 From: NihalHarish Date: Fri, 31 Jul 2020 04:50:34 -0700 Subject: [PATCH 2/2] more verbose enum names --- smdebug/tensorflow/keras.py | 2 +- smdebug/tensorflow/utils.py | 27 ++++++++++++++++----------- 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/smdebug/tensorflow/keras.py b/smdebug/tensorflow/keras.py index 5cf570d6a..d34b645be 100644 --- a/smdebug/tensorflow/keras.py +++ b/smdebug/tensorflow/keras.py @@ -986,7 +986,7 @@ def save_tape_logs(self, model_inputs=None, outputs=None): :param outputs: :return: """ - logs = {ModelOutput.Y_PRED: outputs, ModelInput.X: model_inputs} + logs = {ModelOutput.PREDICTIONS: outputs, ModelInput.INPUTS: model_inputs} self.save_smdebug_logs(logs) def wrap_tape(self, tape): diff --git a/smdebug/tensorflow/utils.py b/smdebug/tensorflow/utils.py index 5f6f7caa8..65d40db65 100644 --- a/smdebug/tensorflow/utils.py +++ b/smdebug/tensorflow/utils.py @@ -14,30 +14,35 @@ class ModelOutput: - Y = "smdebug_y" - Y_PRED = "smdebug_y_pred" - VAL_Y = "val_smdebug_y" - VAL_Y_PRED = "val_smdebug_y_pred" + LABELS = "smdebug_y" + PREDICTIONS = "smdebug_y_pred" + VAL_LABELS = "val_smdebug_y" + VAL_PREDICTIONS = "val_smdebug_y_pred" -ModelOutputs = {ModelOutput.Y, ModelOutput.Y_PRED, ModelOutput.VAL_Y, ModelOutput.VAL_Y_PRED} +ModelOutputs = { + ModelOutput.LABELS, + ModelOutput.PREDICTIONS, + ModelOutput.VAL_LABELS, + ModelOutput.VAL_PREDICTIONS, +} def get_model_output_export_name(key): export_names = { - ModelOutput.Y_PRED: "predictions", - ModelOutput.Y: "labels", - ModelOutput.VAL_Y: "labels", - ModelOutput.VAL_Y_PRED: "predictions", + ModelOutput.PREDICTIONS: "predictions", + ModelOutput.LABELS: "labels", + ModelOutput.VAL_LABELS: "labels", + ModelOutput.VAL_PREDICTIONS: "predictions", } return export_names[key] class ModelInput: - X = "smdebug_x" + INPUTS = "smdebug_x" -ModelInputs = {ModelInput.X} +ModelInputs = {ModelInput.INPUTS} def get_model_input_export_name():