Use SMP rank and size when applicable #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul003
requested review from
NihalHarish and
leleamol
and removed request for
NihalHarish
Vikas-kum
reviewed
Dec 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
- Coverage 77.70% 76.13% -1.58%
==========================================
Files 113 113
Lines 10139 10165 +26
==========================================
- Hits 7879 7739 -140
- Misses 2260 2426 +166
Continue to review full report at Codecov.
|
Contributor
Author
|
ok, will do |
NihalHarish
suggested changes
Dec 16, 2020
NihalHarish
approved these changes
Jan 11, 2021
rahul003
changed the title
NihalHarish
added a commit
that referenced
this pull request
Jan 15, 2021
This reverts commit 07a3fd9.
ndodda-amazon
added a commit
that referenced
this pull request
Jan 16, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 20, 2021
* Add smp rank * Switch to core initialize * Use smp size * Cache whether SMP can be imported * Lint * try import with noqa' * Add smp rank call in core * Import only once * Use nested except blocks
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 20, 2021
* Add smp rank * Switch to core initialize * Use smp size * Cache whether SMP can be imported * Lint * try import with noqa' * Add smp rank call in core * Import only once * Use nested except blocks
NihalHarish
pushed a commit
that referenced
this pull request
Jan 25, 2021
* Add smp rank * Switch to core initialize * Use smp size * Cache whether SMP can be imported * Lint * try import with noqa' * Add smp rank call in core * Import only once * Use nested except blocks
NihalHarish
added a commit
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When SMP is used together with Horovod, there'll be multiple horovod 'groups'. Rank and size need to be queried from SMP in such cases.
This is not a problem for Pytorch as there is a single torch.distributed group there or MXNet as SMP doesn't support MXNet.