Revert "Use SMP rank and size when applicable" #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 07a3fd9.
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
===========================================
- Coverage 77.95% 40.95% -37.00%
===========================================
Files 113 113
Lines 10169 10143 -26
===========================================
- Hits 7927 4154 -3773
- Misses 2242 5989 +3747
Continue to review full report at Codecov.
|
rahul003
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #411. #411 reintroduced two different bugs:
smdataparallelwithout conditioning oncheck_smdataparallel_env()smdataparallelgloballyThe primary issue is that
check_smdataparallel_envmust be checked first before attempting to import. Attempting to importsmdataparallelwithout the environment variable being set and being initialized via MPI will trigger failures in any non-SMP jobs. This has caused multiple failures in our profiler integration tests.The solution is straightforward - move the imports back to
get_distributed_workerand only attempt to import ifcheck_smdataparallel_envis True.TODO: Introduce profiler integration tests as a part of the CI to prevent this kind of issue from happening again.