Fix BatchSemaphore bug causing deadlocks #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarsko
reviewed
Dec 3, 2024
jorajeev
force-pushed
the
batch-semaphore-drop-fix
branch
2 times, most recently
from
05b1f82 to
370c74d
Compare
…ocks in the presence of tasks that gave up waiting for requested permits, under the policy of strict fairness. --------- Co-authored-by: Sarek Høverstad Skotåm <sarek.skotam@gmail.com>
jorajeev
force-pushed
the
batch-semaphore-drop-fix
branch
from
370c74d to
0a4f0bb
Compare
sarsko
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in BatchSemaphore that caused deadlocks in the presence of tasks that gave up waiting for requested permits, under the policy of strict fairness.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.