Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating save-state and set-output commands #22

Closed
Boehrsi opened this issue Mar 23, 2023 · 7 comments
Closed

Deprecating save-state and set-output commands #22

Boehrsi opened this issue Mar 23, 2023 · 7 comments

Comments

@Boehrsi
Copy link

Boehrsi commented Mar 23, 2023

It seems that GitHub updated some internal stuff and GitHub Actions must be updated until 31st May 2023, otherwise the action will fail with an error. More information: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I encounter the following messages during builds:

  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  total: 130
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  total_max: 130
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  conventions: 30
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  conventions_max: 30
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  documentation: 10
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  documentation_max: 10
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  platforms: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  platforms_max: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  analysis: 30
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  analysis_max: 30
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  dependencies: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  dependencies_max: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  null_safety: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  null_safety_max: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I get the mentioned warnings during the Setting outputs part of the action.
Thanks for the really helpful action by the way!

@JaffaKetchup
Copy link

Hey @axel-op, this deadline is getting quite close now! Any chance of this being updated?

@axel-op
Copy link
Owner

axel-op commented May 5, 2023

Hello,

Thank you for the issue. I've updated the GitHub Actions toolkit to use the environment files when setting an output. Please wait a few hours for the Docker image to be regenerated with this modification.

Also, sorry for the delay. I've been pretty busy these last weeks but I should now be able to respond in a more timely manner.

@axel-op axel-op closed this as completed May 5, 2023
@JaffaKetchup
Copy link

Thanks @axel-op :)
No worries about the wait.

@JaffaKetchup
Copy link

Hey @axel-op, sorry to bother you again ;|
Not sure if this has worked fully, or if it's an issue with my implementation?

image

I use this code as well, but I don't think that it's an issue?
image

Thanks for all your great work :)

@axel-op axel-op reopened this May 12, 2023
JaffaKetchup added a commit to fleaflet/flutter_map that referenced this issue May 12, 2023
Uses Firebase Hosting & https://github.com/FirebaseExtended/action-hosting-deploy to build and deploy the example app on web.
Creates preview sites for PRs, and deploys to the live site on pushes to the master branch.

We're looking for FirebaseExtended/action-hosting-deploy#279 to be merged by 2023/05/31.
We're looking for axel-op/dart-package-analyzer#22 to be resolved by 2023/05/31.
Otherwise, this action will fail (note that the existing action will fail by this date currently anyway).
@axel-op
Copy link
Owner

axel-op commented May 12, 2023

@JaffaKetchup My bad, I fixed the issue for environment variables but not for outputs! This should now be totally corrected :)

@JaffaKetchup
Copy link

Thanks @axel-op, certainly seems to be fixed!

@Boehrsi
Copy link
Author

Boehrsi commented May 12, 2023

I can also confirm it's working now, thanks @axel-op

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants