Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: enable brew style in linters #1354

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Commits on Aug 21, 2024

  1. tests: enable brew style in linters

    This adds a `brew style` linter to make sure that our generated Homebrew
    formulas will pass Homebrew's `brew style` for users who have enabled Homebrew's
    default CI setup for their taps. I've also ensured our snapshots contain the
    auto-restyled copies after `brew style --fix` is run.
    
    This required one stylistic change: the hashmap for binary aliases would
    violate the line length lint, and unfortunately Rubocop's line length autoformatter
    was consistently getting the formatting wrong. This instead (ab)uses the fact that
    JSON hashmaps have a compatible syntax to Ruby 1.9+ hashmaps so long as symbols
    are the keys - and we were already using symbolized keys. The resulting hashmap
    is slightly strange-looking by Ruby standards, since symbolized keys usually aren't
    quoted, but Rubocop isn't mad about it.
    mistydemeo committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9c45a4c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6abd080 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ea8ec8e View commit details
    Browse the repository at this point in the history