Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure that the bias is also in the correct dtype #1848

Merged
merged 2 commits into from
Aug 22, 2024
Merged

ensure that the bias is also in the correct dtype #1848

merged 2 commits into from
Aug 22, 2024

Conversation

winglian
Copy link
Collaborator

@winglian winglian merged commit 5b0b774 into main Aug 22, 2024
7 checks passed
@winglian winglian deleted the dpo-fsdp-qlora branch August 22, 2024 15:45
@BenjaminBossan
Copy link

Thanks for working on this fix. Could the added unit test be used to reproduce the original error (when using axolotl from before the fix)?

@winglian
Copy link
Collaborator Author

Thanks for working on this fix. Could the added unit test be used to reproduce the original error (when using axolotl from before the fix)?

Correct! That's the same configuration I was using to manually test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New changes in PEFT breaks FSDP (RLHF)
2 participants
@winglian @BenjaminBossan