Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove default value 0000 0000 0000 0000 of Hex #1482

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

What this PR does / why we need it?

This PR closes #1388.

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@yangby-cryptape

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

@yangby-cryptape yangby-cryptape force-pushed the yangby/refactor/default-value-of-hex branch from bd42f15 to 8f4cd24 Compare October 16, 2023 09:19
@yangby-cryptape yangby-cryptape changed the title refactor: set default value of Hex to 0x refactor: remove default value 0000 0000 0000 0000 of Hex Oct 16, 2023
@yangby-cryptape

This comment was marked as off-topic.

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@yangby-cryptape yangby-cryptape marked this pull request as ready for review October 16, 2023 10:12
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner October 16, 2023 10:12
@yangby-cryptape yangby-cryptape requested review from blckngm, wenyuanhust, Flouse, driftluo and KaoImin and removed request for blckngm and wenyuanhust October 16, 2023 10:12
@KaoImin KaoImin enabled auto-merge October 17, 2023 07:29
@KaoImin KaoImin added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit 31d64de Oct 17, 2023
19 of 20 checks passed
@KaoImin KaoImin deleted the yangby/refactor/default-value-of-hex branch October 17, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discuss] Is it common sense to set vec![0u8; 8] as the default value of Hex?
3 participants