Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CkbType.sol for consistent ABI output with json file #1558

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

sunchengzhu
Copy link
Collaborator

@sunchengzhu sunchengzhu commented Nov 14, 2023

What this PR does / why we need it?

This PR updates CkbType.sol to ensure the compiled ABI from the source CkbLightClient.sol file remains consistent with ckb_light_client_abi.json.

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@sunchengzhu sunchengzhu requested a review from a team as a code owner November 14, 2023 11:42
@github-actions github-actions bot added the chore label Nov 14, 2023
@KaoImin KaoImin added this pull request to the merge queue Nov 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 15, 2023
@chaoticlonghair
Copy link
Contributor

E2E test failed in merge queue.

Error: Jest: Got error running globalSetup - /home/runner/work/axon/axon/tests/e2e/jest/setup.js, reason: Node is detached from document

@chaoticlonghair chaoticlonghair added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 79be7c1 Nov 15, 2023
@sunchengzhu sunchengzhu deleted the scz/update-ckb_light_client-sol branch November 16, 2023 11:28
KaoImin pushed a commit that referenced this pull request Nov 17, 2023
…1558)

Update CkbType.sol for consistent JSON output with ckb_light_client_abi.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants