-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration-test: Implement running on VMs #733
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| [package] | ||
| name = "init" | ||
| version = "0.1.0" | ||
| authors = ["Tamir Duberstein <tamird@gmail.com>"] | ||
| edition = "2021" | ||
| publish = false | ||
|
|
||
| [dependencies] | ||
| anyhow = { workspace = true, features = ["std"] } | ||
| nix = { workspace = true, features = ["fs", "mount", "reboot"] } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,166 @@ | ||
| //! init is the first process started by the kernel. | ||
| //! | ||
| //! This implementation creates the minimal mounts required to run BPF programs, runs all binaries | ||
| //! in /bin, prints a final message ("init: success|failure"), and powers off the machine. | ||
|
|
||
| use anyhow::Context as _; | ||
|
|
||
| #[derive(Debug)] | ||
| struct Errors(Vec<anyhow::Error>); | ||
|
|
||
| impl std::fmt::Display for Errors { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| let Self(errors) = self; | ||
| for (i, error) in errors.iter().enumerate() { | ||
| if i != 0 { | ||
| writeln!(f)?; | ||
| } | ||
| write!(f, "{:?}", error)?; | ||
| } | ||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| impl std::error::Error for Errors {} | ||
|
|
||
| fn run() -> anyhow::Result<()> { | ||
| const RXRXRX: nix::sys::stat::Mode = nix::sys::stat::Mode::empty() | ||
| .union(nix::sys::stat::Mode::S_IRUSR) | ||
| .union(nix::sys::stat::Mode::S_IXUSR) | ||
| .union(nix::sys::stat::Mode::S_IRGRP) | ||
| .union(nix::sys::stat::Mode::S_IXGRP) | ||
| .union(nix::sys::stat::Mode::S_IROTH) | ||
| .union(nix::sys::stat::Mode::S_IXOTH); | ||
|
|
||
| struct Mount { | ||
| source: &'static str, | ||
| target: &'static str, | ||
| fstype: &'static str, | ||
| flags: nix::mount::MsFlags, | ||
| data: Option<&'static str>, | ||
| target_mode: Option<nix::sys::stat::Mode>, | ||
| } | ||
|
|
||
| for Mount { | ||
| source, | ||
| target, | ||
| fstype, | ||
| flags, | ||
| data, | ||
| target_mode, | ||
| } in [ | ||
| Mount { | ||
| source: "proc", | ||
| target: "/proc", | ||
| fstype: "proc", | ||
| flags: nix::mount::MsFlags::empty(), | ||
| data: None, | ||
| target_mode: Some(RXRXRX), | ||
| }, | ||
| Mount { | ||
| source: "sysfs", | ||
| target: "/sys", | ||
| fstype: "sysfs", | ||
| flags: nix::mount::MsFlags::empty(), | ||
| data: None, | ||
| target_mode: Some(RXRXRX), | ||
| }, | ||
| Mount { | ||
| source: "debugfs", | ||
| target: "/sys/kernel/debug", | ||
| fstype: "debugfs", | ||
| flags: nix::mount::MsFlags::empty(), | ||
| data: None, | ||
| target_mode: None, | ||
| }, | ||
| Mount { | ||
| source: "bpffs", | ||
| target: "/sys/fs/bpf", | ||
| fstype: "bpf", | ||
| flags: nix::mount::MsFlags::empty(), | ||
| data: None, | ||
| target_mode: None, | ||
| }, | ||
| ] { | ||
| match target_mode { | ||
| None => { | ||
| // Must exist. | ||
| let nix::sys::stat::FileStat { st_mode, .. } = nix::sys::stat::stat(target) | ||
| .with_context(|| format!("stat({target}) failed"))?; | ||
dave-tucker marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| let s_flag = nix::sys::stat::SFlag::from_bits_truncate(st_mode); | ||
|
|
||
| if !s_flag.contains(nix::sys::stat::SFlag::S_IFDIR) { | ||
| anyhow::bail!("{target} is not a directory"); | ||
| } | ||
| } | ||
| Some(target_mode) => { | ||
| // Must not exist. | ||
| nix::unistd::mkdir(target, target_mode) | ||
| .with_context(|| format!("mkdir({target}) failed"))?; | ||
| } | ||
| } | ||
| nix::mount::mount(Some(source), target, Some(fstype), flags, data).with_context(|| { | ||
| format!("mount({source}, {target}, {fstype}, {flags:?}, {data:?}) failed") | ||
| })?; | ||
| } | ||
|
|
||
| // By contract we run everything in /bin and assume they're rust test binaries. | ||
| // | ||
| // If the user requested command line arguments, they're named init.arg={}. | ||
|
|
||
| // Read kernel parameters from /proc/cmdline. They're space separated on a single line. | ||
| let cmdline = std::fs::read_to_string("/proc/cmdline") | ||
| .with_context(|| "read_to_string(/proc/cmdline) failed")?; | ||
| let args = cmdline | ||
| .split_whitespace() | ||
| .filter_map(|parameter| { | ||
| parameter | ||
| .strip_prefix("init.arg=") | ||
| .map(std::ffi::OsString::from) | ||
| }) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| // Iterate files in /bin. | ||
| let read_dir = std::fs::read_dir("/bin").context("read_dir(/bin) failed")?; | ||
dave-tucker marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| let errors = read_dir | ||
| .filter_map(|entry| { | ||
| match (|| { | ||
| let entry = entry.context("read_dir(/bin) failed")?; | ||
| let path = entry.path(); | ||
| let status = std::process::Command::new(&path) | ||
| .args(&args) | ||
| .status() | ||
| .with_context(|| format!("failed to execute {}", path.display()))?; | ||
|
|
||
| if status.code() == Some(0) { | ||
| Ok(()) | ||
| } else { | ||
| Err(anyhow::anyhow!("{} failed: {status:?}", path.display())) | ||
| } | ||
| })() { | ||
| Ok(()) => None, | ||
| Err(err) => Some(err), | ||
| } | ||
| }) | ||
| .collect::<Vec<_>>(); | ||
| if errors.is_empty() { | ||
| Ok(()) | ||
| } else { | ||
| Err(Errors(errors).into()) | ||
| } | ||
| } | ||
|
|
||
| fn main() { | ||
| match run() { | ||
| Ok(()) => { | ||
| println!("init: success"); | ||
| } | ||
| Err(err) => { | ||
| println!("{err:?}"); | ||
| println!("init: failure"); | ||
dave-tucker marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| let how = nix::sys::reboot::RebootMode::RB_POWER_OFF; | ||
| let _: std::convert::Infallible = nix::sys::reboot::reboot(how) | ||
| .unwrap_or_else(|err| panic!("reboot({how:?}) failed: {err:?}")); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I for one am very pro
nixand have 0 objections to using it inxtask.ISTR in any we only used
libcand I don't think we need to be as strict, but flagging it anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack.