Skip to content
This repository has been archived by the owner on Aug 31, 2018. It is now read-only.

Commit

Permalink
test: http2 emitGoAway post shutdown pre destroy
Browse files Browse the repository at this point in the history
This commit tests use case when emitGoAway is called when client is
shutting down but is not destroyed.

Refs: nodejs/node#14985
PR-URL: nodejs/node#16215
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
trivikr authored and addaleax committed Oct 18, 2017
1 parent bfc4670 commit c288f99
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/parallel/test-http2-goaway-opaquedata.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ server.listen(0, () => {
assert.deepStrictEqual(code, 1);
assert.deepStrictEqual(lastStreamID, 0);
assert.deepStrictEqual(data, buf);
// Call shutdown() here so that emitGoaway calls destroy()
client.shutdown();
server.close();
}));
const req = client.request({ ':path': '/' });
Expand Down

0 comments on commit c288f99

Please sign in to comment.