Add a correct content type to POST requests and SearchFilters adjustments #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
changed the title
pomadchin
force-pushed
the
fix/client-media-type
branch
2 times, most recently
from
497a6bd
to
9247181
Compare
pomadchin
force-pushed
the
fix/client-media-type
branch
from
9247181
to
d49d887
Compare
pomadchin
changed the title
pomadchin
force-pushed
the
fix/client-media-type
branch
from
283cff6
to
9426ea9
Compare
pomadchin
force-pushed
the
fix/client-media-type
branch
2 times, most recently
from
3cedcb5
to
1786ab2
Compare
pomadchin
force-pushed
the
fix/client-media-type
branch
from
1786ab2
to
47233d5
Compare
jisantuc
approved these changes
Jul 6, 2021
modules/client/js/src/main/scala/com/azavea/stac4s/api/client/SearchFilters.scala
Outdated
Show resolved
Hide resolved
modules/client/shared/src/main/scala/com/azavea/stac4s/api/client/SttpStacClientF.scala
Show resolved
Hide resolved
pomadchin
commented
Jul 6, 2021
modules/client/jvm/src/main/scala/com/azavea/stac4s/api/client/SearchFilters.scala
Show resolved
Hide resolved
jisantuc
approved these changes
Jul 6, 2021
modules/client/js/src/main/scala/com/azavea/stac4s/api/client/SearchFilters.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR sets content type to all client post requests as well as adjusts SearchFilters (make all fields optional + drop nulls in requests) case class to make client more compatible with different STAC API Implementations.
Checklist
chan)