From b1e50171a7a8b927624cb50f03b3ee4c3e9667b8 Mon Sep 17 00:00:00 2001 From: PatrickMenoti Date: Fri, 3 Mar 2023 10:11:22 -0300 Subject: [PATCH] chore: change listing and unit test --- pkg/cmd/domains/list/list.go | 4 ++-- utils/helpers_test.go | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/domains/list/list.go b/pkg/cmd/domains/list/list.go index 4c84425bc..a9859f7cd 100644 --- a/pkg/cmd/domains/list/list.go +++ b/pkg/cmd/domains/list/list.go @@ -52,7 +52,7 @@ func PrintTable(cmd *cobra.Command, f *cmdutil.Factory, opts *contracts.ListOpti tbl := table.New("ID", "NAME") table.DefaultWriter = f.IOStreams.Out if cmd.Flags().Changed("details") { - tbl = table.New("ID", "NAME", "EDGE DOMAIN", "ACTIVE", "DIGITAL CERTIFICATE ID", "EDGE APPLICATION ID", "CNAME ACCESS ONLY", "CNAMES") + tbl = table.New("ID", "NAME", "EDGE DOMAIN", "DIGITAL CERTIFICATE ID", "EDGE APPLICATION ID", "CNAME ACCESS ONLY", "CNAMES", "ACTIVE") } headerFmt := color.New(color.FgBlue, color.Underline).SprintfFunc() @@ -61,7 +61,7 @@ func PrintTable(cmd *cobra.Command, f *cmdutil.Factory, opts *contracts.ListOpti if cmd.Flags().Changed("details") { for _, v := range domains.Results { - tbl.AddRow(v.Id, v.Name, *v.DomainName, *v.IsActive, v.DigitalCertificateId.Get(), *v.EdgeApplicationId, *v.CnameAccessOnly, *v.Cnames) + tbl.AddRow(v.Id, v.Name, *v.DomainName, v.DigitalCertificateId.Get(), *v.EdgeApplicationId, *v.CnameAccessOnly, *v.Cnames, *v.IsActive) } } else { for _, v := range domains.Results { diff --git a/utils/helpers_test.go b/utils/helpers_test.go index 41f273122..a4bd0cc0e 100644 --- a/utils/helpers_test.go +++ b/utils/helpers_test.go @@ -85,4 +85,11 @@ func TestCobraCmd(t *testing.T) { require.Contains(t, azJsonData.Function.File, "myfile.js") require.EqualValues(t, azJsonData.Function.Id, 476) }) + + t.Run("returns invalid order_by", func(t *testing.T) { + body := `{"invalid_order_field":"'edge_domain' is not a valid option for 'order_by'","available_order_fields":["id","name","cnames","cname_access_only","digital_certificate_id","edge_application_id","is_active"]}` + err := checkOrderField(body) + + require.Equal(t, `'edge_domain' is not a valid option for 'order_by'`, err.Error()) + }) }