forked from Azure/azure-sdk-for-js
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoPR @azure/arm-machinelearning] Spark Job mfe contract to 2024-04-01 GA version #8720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
azure-sdk
force-pushed
the
sdkAuto/27930/@azure_arm-machinelearning
branch
3 times, most recently
from
February 28, 2024 05:21
1cc6b74
to
dbb9bf8
Compare
…ents (Azure#28823) ### Packages impacted by this PR @azure/monitor-opentelemetry
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7842 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Anne Thompson <annelo@microsoft.com>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7835 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
…ure#28842) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7845 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
### Packages impacted by this PR @azure/identity ### Issues associated with this PR Nightly test failures ### Describe the problem that is addressed by this PR Our nightly tests started failing with a `TypeError: Descriptor for property generatePluginConfiguration is non-configurable and non-writable` error. I'm far from an expert here, but I believe the error is due to ESModules being immutable, whereas CJS Modules are mutable. Wrapping the stubbable / mockable object is a reasonable workaround to keep tests green regardless of whether they get run as ESM or CJS ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? Deleting the tests is an option, or an integration test. Neither seem to fit the bill here. Once we have credentials migrated over we may be able to delete some of the unit tests and rely on recorded tests to test the various scenarios. But we are not there yet.
azure-sdk
force-pushed
the
sdkAuto/27930/@azure_arm-machinelearning
branch
from
March 8, 2024 20:42
dbb9bf8
to
210e3db
Compare
… Package (Azure#28827) ### Packages impacted by this PR @azure/monitor-opentelemetry ### Describe the problem that is addressed by this PR Package should be updated to the latest version and tests updated appropriately. ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
### Packages impacted by this PR @azure/core-client ### Issues associated with this PR N/A, follow up on Azure#28631 ### Describe the problem that is addressed by this PR If you are exporting both CommonJS and ESM forms of a package, then it is possible for both versions to be loaded at run-time. However, the CommonJS build is a different module from the ESM build, and thus a different thing from the point of view of the JavaScript interpreter in Node.js. https://github.com/isaacs/tshy/blob/main/README.md#dual-package-hazards tshy handles this by building programs into separate folders and treats "dual module hazards" as a fact of life. One of the hazards of dual-modules is shared module-global state. In core-clientwe have a module-global operationRequestMap that is used for deserializing. In order to ensure it works in this dual-package world we must use one of multiple-recommended workarounds. In this case, the tshy documentation provides a solution to this with a well-documented path forward. This is what is implemented here. Please refer to https://github.com/isaacs/tshy/blob/main/README.md#module-local-state for added context ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? The obvious alternative is to just not do anything since tests have not been failing; however, that seems risky. While _this_ particular issue has not come up in tests, a similar one came up for core-tracing. I am open to just _not_ doing anything of course - I love not adding code so just give me a reason!
…8840) ### Packages impacted by this PR @azure/monitor-opentelemetry-exporter
### Packages impacted by this PR - @azure/dev-tool ### Issues associated with this PR ### Describe the problem that is addressed by this PR Reverts back to the original for the testing ts-node for JS and TS. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ - Azure#28801 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Update emitter packages.
…ure#28864) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7848 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: James Suplizio <jasupliz@microsoft.com>
### Packages impacted by this PR - @azure/keyvault-keys - @azure/keyvault-admin - @azure/keyvault-secrets ### Describe the problem that is addressed by this PR Fixes the glob path issue with the upgrade to `rimraf` since there were extra calls to `rimraf` after the standard calls.
The `azsdkjsrush` storage account has seemingly been deleted, so this will always fail and waste effort during CI. Tracking issue for a full fix: Azure#28865
…n SDK (Azure#28847) ### Describe the problem that is addressed by this PR Added the CreatCallFailed and AnswerFailed event. This changed is tested against the Contoso app.
…ure#28867) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7853 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: James Suplizio <jasupliz@microsoft.com>
### Packages impacted by this PR - `@azure/opentelemetry-instrumentation-azure-sdk` ### Issues associated with this PR ### Describe the problem that is addressed by this PR Updates to latest OTEL ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
### Packages impacted by this PR - @azure-tests/perf-monitor-opentelemetry ### Issues associated with this PR ### Describe the problem that is addressed by this PR Updates to latest OTEL packages ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
- convert pipelines to 1es-templates from all entrypoints. specifically archetype-sdk-tests, archetype-sdk-client, and cosmos-sdk-client. - Move all image selection (outside of release deployments) to honor env variables instead of manually writing the pool (similar patterns for all other platforms) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7854 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
This is an automatic PR generated weekly with changes from running the command rush update --full
### Packages impacted by this PR - @azure/dev-tool ### Issues associated with this PR ### Describe the problem that is addressed by this PR Updates to latest dependencies and move from mocha to vitest. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
### Packages impacted by this PR N/A ### Issues associated with this PR Build failures ### Describe the problem that is addressed by this PR `esm` is slowly becoming a larger problem for us and we've been on a mission to remove it. min/max tests fail because esm is unable to handle safe-navigation operators (?.) While a separate PR switches tests to use tsx, this PR focuses on min/max tests and can be merged separately. ### Provide a list of related PRs _(if any)_ Azure#28826
azure-sdk
force-pushed
the
sdkAuto/27930/@azure_arm-machinelearning
branch
from
March 12, 2024 19:16
210e3db
to
1338d84
Compare
) ### Packages impacted by this PR @azure/monitor-opentelemetry ### Describe the problem that is addressed by this PR Code samples should be consistent and be syntactically correct in TypeScript Azure#28744 ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
…o ESM (Azure#28897) ### Packages impacted by this PR - `@azure/abort-controller` - `@azure/core-auth` - `@azure-rest/core-client` - `@azure/core-client` - `@azure/core-http-compat` - `@azure/core-lro` - `@azure/core-paging` - `@azure/core-rest-pipeline` - `@azure/core-sse` - `@azure/core-tracing` - `@azure/core-util` - `@azure/logger` ### Describe the problem that is addressed by this PR Preparing for upcoming Core release. We are doing a minor version bump for all packages which we have migrated to ESM.
### Packages impacted by this PR @azure/eventgrid ### Issues associated with this PR NA ### Describe the problem that is addressed by this PR The EventGrid Service Team has added 2 new events. The SDK must be regenerated to include the code changes related to these 2 new events. The SDK minor version has been updated. - `Microsoft.ApiCenter.ApiDefinitionAdded` - `Microsoft.ApiCenter.ApiDefinitionUpdated` ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? There are no specific/complex design scenarios for this task. It is a straightforward regenerate and some standard changes to the custom layer of the code. ### Are there test cases added in this PR? _(If not, why?)_ No. This item is standard and we need not add test cases for every new events. The existing cases would be sufficient. ### Provide a list of related PRs _(if any)_ - Azure#27384 (This is the PR that adds similar events to the SDK in the 4.15.0 release) - Azure#26939 (This is the PR that adds similar events to the SDK in the 4.14.0 release) - Azure#26020 (This is the PR that adds similar events to the SDK in the 4.13.0 release) - Azure#28176 (This is the PR that adds similar events to the SDK in the 5.1.0 release) - Azure#28513 (This is the PR that adds similar events to the SDK in the 5.2.0 release) ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ `autorest --typescript swagger\README.md` ### Checklists - [X] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [X] Added a changelog (if necessary)
…zure#26875) ### Packages impacted by this PR - `@azure/keyvault-keys` - `@azure/keyvault-secrets` ### Issues associated with this PR - Fix Azure#22705 ### Describe the problem that is addressed by this PR Brings Keys and Secrets up to speed with the latest keyvault-common goodness
Sync eng/common directory with azure-sdk-tools for PR
### Packages impacted by this PR `@azure/monitor-opentelemetry` `@azure/monitor-opentelemetry-exporter` ### Describe the problem that is addressed by this PR `cross-env` was removed from the devdeps of monitor-opentelemetry and monitor-opentelemetry-exporter which causes pipeline failures when running the test pipeline since the integration test command uses this binary.
azure-sdk
force-pushed
the
sdkAuto/27930/@azure_arm-machinelearning
branch
4 times, most recently
from
March 13, 2024 21:44
ae43015
to
048a458
Compare
### Issues associated with this PR [User Story 3604450](https://skype.visualstudio.com/SPOOL/_workitems/edit/3604450): [Alpha3][NodeJS][Transcription][SDK] Add Transcription packets parser. [User Story 3595649](https://skype.visualstudio.com/SPOOL/_workitems/edit/3595649): [Alpha3][NodeJS][Transcription][SDK] Add Duration for TranscriptionData and Words ### Describe the problem that is addressed by this PR Adding the parser for the stream data
### Packages impacted by this PR - `@azure/core-lro` ### Describe the problem that is addressed by this PR In the ESM migration it appears we accidentally removed the `files` section from package.json for this package, so the built and packed package includes everything including the source code. This PR restores the field in line with the other ESMified Core packages.
azure-sdk
force-pushed
the
sdkAuto/27930/@azure_arm-machinelearning
branch
from
March 13, 2024 23:56
048a458
to
3fc5589
Compare
azure-sdk
force-pushed
the
main
branch
2 times, most recently
from
March 14, 2024 06:30
f9892bb
to
34da487
Compare
### Packages impacted by this PR @azure/monitor-opentelemetry Fixed issue with quickpulse document duration Fixed issue with miscalculation in dependency duration metric Updated default quickpulse endpoint
azure-sdk
force-pushed
the
sdkAuto/27930/@azure_arm-machinelearning
branch
from
March 14, 2024 17:44
3fc5589
to
7ef6951
Compare
Post release automated changes for azure-core-lro
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7877 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
### Packages impacted by this PR `@azure-tools/test-recorder` ### Issues associated with this PR Azure#28667 ### Describe the problem that is addressed by this PR Releasing recorder 3.1.0 unblocks the Azure#28667 that upgrades recorder to 4.0.0 with vitest.
Merge ba1de6af496284a876810d1b4c484be9b8a9371b into e143f1ecf407ec8ff84350d8b88b2af9877d9929
azure-sdk
force-pushed
the
sdkAuto/27930/@azure_arm-machinelearning
branch
from
March 14, 2024 21:02
7ef6951
to
7473c14
Compare
azure-sdk
force-pushed
the
main
branch
2 times, most recently
from
March 18, 2024 05:57
d738efb
to
34da487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#27930
Please install the package by
npm install https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/27930/azure-sdk-for-js/@azure_arm-machinelearning/azure-arm-machinelearning-3.0.0.tgz