Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the rules for calculating holidays in South Korea based on the history of holiday changes. #314

Merged
merged 28 commits into from
Jun 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
8a3554c
Updated KASI paper reference link and added conversion utility link o…
barami May 3, 2023
9f5be3b
Fixed incorrect date of Buddha's Birthday in 2001: Unlike China, Sout…
barami May 3, 2023
2b554fc
Added additional alternative holidays that will be effective May 2023.
barami May 3, 2023
1a0344c
Added methods to the South Korea provider to generate holidays that w…
barami May 3, 2023
53f711b
Added constant holds collection of historically recognized holidays a…
barami May 4, 2023
f083dd1
Fix up incorrect date for dayAfterSeollal
barami May 5, 2023
bf2152d
Modify calculateOldSubstituteHolidays and calculateSubstituteHolidays…
barami May 5, 2023
0700af3
Add substitution cases for 1959, 1960, 1989 to calculateOldSubstitute…
barami May 5, 2023
134daf1
Changed the incorrect founding year of Armed Forces Day in the ArmedF…
barami May 5, 2023
2858120
Extract the list of holidays eligible for alternative holidays into a…
barami May 6, 2023
a87a011
Copy the description of the holiday into the generator method and mod…
barami May 7, 2023
e0ad97e
Refactored the rules for calculating holidays in South Korea based on…
barami May 7, 2023
5c86ac2
Fixed the SouthKoreaTest test because the year that Armed Forces Day …
barami May 7, 2023
a5681d8
Modify based on the results of the composer format command
barami May 7, 2023
20aa6d4
Modify based on the results of the composer phpstan command
barami May 7, 2023
4bfa77e
Modify note of calculateCurrent
barami May 7, 2023
5e6a509
Added substitute holiday tests for Buddha's Day and Christmas Day
barami May 12, 2023
b2c2347
Modified testing for the Seollal to match the year it was declared a …
barami May 12, 2023
ef3c7b6
Fixed an incorrect holiday year of enactment.
barami May 12, 2023
b252e73
Fixed test cases related to Arbor Day 1960.
barami May 12, 2023
3cb3c38
Added tests for United Nations Day.
barami May 13, 2023
a906e5d
Changed to remove the SouthKorea dependency from the lunar holidays t…
barami May 13, 2023
b43a5ee
SouthKoreaTest: refactored the test case.
barami May 14, 2023
b7b506c
Refactored by merging the calculate methods of SouthKorea provider.
barami May 14, 2023
6ba60a6
Modify based on the results of the composer format command
barami May 14, 2023
18e3e40
Fix up incorrect year of Chuseok in 1995
barami May 15, 2023
eb026b3
Apply code style changes from commit f50c537a5cfccde7b600055990a31ed9…
barami May 25, 2023
9642036
Updated CHANGELOG for this pr.
barami May 25, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,23 @@ changes.

### Added

- Recently, the South Korean government announced a bill to apply alternative public holidays to Buddha's Day
and Christmas Day, which we have reflected in our South Korea provider.
[\#314](https://github.com/azuyalabs/yasumi/pull/314) ([barami](https://github.com/barami))

### Changed

- Updated links to related documentation in the SouthKorea provider's note and added links to conversion utilities.
[\#314](https://github.com/azuyalabs/yasumi/pull/314) ([barami](https://github.com/barami))
- Refactored the complexity of the SouthKorea provider to make it easier to understand in case of future changes.
[\#314](https://github.com/azuyalabs/yasumi/pull/314) ([barami](https://github.com/barami))

### Fixed

- Fixed a bug in the South Korea provider where some of the past dates for Buddha's Day, Chuseok, Armed Forces Day
and United Nations Day were incorrect during holidays, and modified the unit tests accordingly.
[\#314](https://github.com/azuyalabs/yasumi/pull/314) ([barami](https://github.com/barami))

### Removed

## [2.6.0] - 2023-04-27
Expand Down
Loading