Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump up cosmos-sdk v0.50.8, cometbft v0.38.9, ibc-go v8.3.2 #79

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Jul 25, 2024

Description

  • cosmos-sdk v0.50.6 -> v0.50.8
  • cometbft v0.38.6 -> v0.38.9
  • ibc-go v8.2.1 -> v8.3.2

I synced ibc/testing, which is used for testing in the onboarding module, with codes from cosmos/ibc-go@v8.3.2 and removed un-necessary files. However, this is a temporary measure and I will eventually move towards removing ibc/testing and utilising ibc-go.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 self-assigned this Jul 25, 2024
@dudong2 dudong2 changed the title feat: bump up cosmos-sdk v0.50.7, cometbft v0.38.7, ibc-go v8.3.2 feat: bump up cosmos-sdk v0.50.8, cometbft v0.38.9, ibc-go v8.3.2 Jul 26, 2024
Copy link
Member

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems need to bump ethermint to b-harvest/ethermint#13 after merged

@dongsam dongsam self-requested a review July 26, 2024 08:55
Copy link

@poorphd poorphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 874a1a9 into v8/develop Jul 26, 2024
8 checks passed
@dudong2 dudong2 deleted the patch/bump-versions branch July 26, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants