Next level visual fix #6

ASecondGuy · 2022-06-30T17:52:15Z

Description

refactoring of the scene tree.

Type of change

Bug fix (non breaking change that fixes an issue)
New feature (non breaking change that adds functionality)
Tooling (non breaking change that adds functionality to the workflow)
Breaking change (fix or feature that causes existing functionality to not work as expected)

Testing

I ran the game multiple times and opened/closed many windows/games.

Checklist

My code follows the general style guidelines of the project
I have perfomed a self-review of my code
I have commented my code, particulary where it is unclear
My changes generate no new warnings or errors
The project compiles and runs correctly

Merge Next level visual

…into b7g-next-level-visual # Conflicts: # game/app/scenes/menu.tscn

Merge B7g next level visual

ASecondGuy · 2022-06-30T17:57:59Z

The merge broke stuff.
I'm gonna fix it real quick.

ASecondGuy · 2022-06-30T18:06:36Z

It's fixed.
Everything ready to be merged.

ASecondGuy · 2022-06-30T18:31:05Z

@RedstoneMedia I think this is everything. Could you take a look at it?

RedstoneMedia · 2022-06-30T19:24:49Z

Ok so the assertion error is now fixed, and the files are named correctly.
However:

You have way too small margins (especially in the game card)
You added a border to things that previously haven't had one (borders aren't always bad, but it doesn't look good in this case)
Some colors are now to dark (game card background). Menu bar background is now too light
Second, darker color on the bottom of the game card info pop-up was removed by you
Font size (And type) was changed for some components (not the game cards)

Currently, I don't see any other issues than this

Edit: Removing basically all margin containers (And overrides that could create these margins) sure cuts down on the complexity of the scene tree, however in this case, maybe that wasn't the best option.

ASecondGuy · 2022-06-30T19:38:18Z

Thanks for the feedback.
PanelContainers have a content margin build in so MarginContainers were redundant where I removed them.
The rest is all just visual stuff.
I could improve the looks (and probably will) but I think it's better if someone with a feeling for that would do it right the first time.

ASecondGuy · 2022-06-30T22:22:39Z

@RedstoneMedia I went and searched for the old values.
I can barely distinguish the 2 versions now.
I think this is good enough. Looking back I should have done this right from the start.

ASecondGuy · 2022-07-01T12:04:20Z

@b7g This is ready to be merged

RedstoneMedia · 2022-07-01T13:18:18Z

Some of the colors and margins are still not exactly right. But this is definitely better (Also thanks for ignoring this: ASecondGuy#7 and then creating your own commit to the thing you said you wouldn't fix 😀)

ASecondGuy · 2022-07-01T13:33:30Z

Some of the colors and margins are still not exactly right. But this is definitely better (Also thanks for ignoring this: ASecondGuy#7 and then creating your own commit to the thing you said you wouldn't fix 😀)

Sorry. I just saw that this morning. That's on me.

b7g · 2022-07-01T13:41:28Z

You are trolling me right?
I will not merge this.

GETTA YO FUXKEN BBCODE OUTTA THERE

also

In the current state it destroys the visual appearance at many places

it has 2 links in blue, one in white
one link does not work
line-spacing is gone
margins are gone at many places

Numenter · 2022-07-01T21:56:35Z

Im looking into the about:_process()
"_write_to_label" fails in "_notification" and "set_text" only in the beginning.
a "_write_to_label" in "_ready" fixs that.

Im not able to break it after this.

ASecondGuy · 2022-07-01T21:59:19Z

Last time I checked it also fails when the scene changes. Ready is not called in that case.

RedstoneMedia · 2022-07-01T22:48:21Z

There is a gap between header and body

To fix this just set the separation, of the root menu node to 0 (currently not overridden)

the game info popup right section lost it’s white space

Set the VC stretch ratio under the InfoSection (In the game card) to 1 instead of 0.4 (Who even did that ?)

the game info popup lost it’s shadow

Replace the empty style box with a StyleBoxFlat.
Unset draw center.
Set the shadow size to 6 and the color to #22000000

I think these changes are so simple that I won't even have to make a PR for this.

Numenter · 2022-07-01T23:29:37Z

Last time I checked it also fails when the scene changes. Ready is not called in that case.

I drilled some more and "set_text" is triggered on scene change. ( text == "" and val == 'old text content' ).
So nothing changes at runtime, can be ignored.
It happens because text is an export and the scene value differs from default. Is some engine woodoo.

There is a comment that it fails in editor. I cant reproduce that.

ASecondGuy · 2022-07-02T07:08:32Z

Set the VC stretch ratio under the InfoSection (In the game card) to 1 instead of 0.4 (Who even did that ?)

I did that. We both fixed the same problem at the same time from different sides. That overcompensated.

The first link had "" while the others didn't. That might be why it didn't work for you @b7g please confirm that it works now.

@Numenter thanks for looking into that. I'll try to fix it asap.

b7g · 2022-07-02T13:59:02Z

Yes, the link works now.

still … “refactoring of the scene tree.”:

It’s awful.

The line spacing in the about tab is still missing too

RedstoneMedia · 2022-07-02T14:32:27Z

If you also mean the change of the "Spielzeit" location on the game card from bottom to top:
I actually think that it looks better when it's aligned on the top.

Your comparison does show some differences, however I think it's important to state that not every change is automatically a flaw (The user will only see one version and won't be able to nitpick the difference s like we are doing right now)

b7g · 2022-07-02T14:58:49Z

Yes, I agree.
Still it’s not just a “refactoring of the scene tree.” and feels like a downgrade visually.

To be clear: The playtime location is on the bottom with this PR and it looks terrible.

To merge this I will also require:

that line-spacing in the about section is added again

It would be nice, if:

the spacing after the logo badge would be added again
the line spacing in the description of the game card and game card info popup is added again

I know it’s terrible hard for you to move your finger for a few pixels, but things were placed with consideration.
And you are breaking through that like an elephant in a flowerbed.

RedstoneMedia · 2022-07-02T15:53:46Z

Please keep your personal issues with others out of this thread, as it doesn't help the current discussion.
Also, who are you even referring to ?

Btw.: @ASecondGuy I opened a PR to fix the play time text location ASecondGuy#8

ASecondGuy · 2022-07-02T15:58:22Z

Just as I finished it too...
Btw. what is the problem with the linespacing.
I don't know what is supposed to be wrong with that.

b7g · 2022-07-02T15:58:30Z

You refers to the PR

ASecondGuy · 2022-07-02T16:02:02Z

You refers to the PR

Please be nice to the PR. It might not have a brain or a body or a consciousness or fingers it could move but it does have feelings

RedstoneMedia · 2022-07-02T16:02:21Z

Just as I finished it too...

Bruh.

Ff this goes on we need to actually start to coordinate our actions (This requires a reliable and fast form of communication (Not GitHub or Discord)). I don't like wasting my time

b7g · 2022-07-02T16:03:45Z

RedstoneMedia · 2022-07-02T16:04:46Z

Where does it even look like that?

ASecondGuy · 2022-07-02T16:07:46Z

It works on my machine ;)

Please send a real screenshot I can't look at your screen in case you didn't know.

b7g · 2022-07-02T16:12:05Z

It’s exaggerated…
I don’t expect that you (the PR) have any knowledge about Typography.

left is this PR

…/Suffragium into asecondguy-next-level-visual-fix-fix

…-fix-fix Fixed play time game card position

This reverts commit 8e271ad.

b7g · 2022-07-02T17:09:14Z

thanks 🏈

RedstoneMedia · 2022-07-02T17:15:52Z

🏈

ASecondGuy · 2022-07-02T17:35:54Z

🏈

…5-additions Sort It physics godot3.5 fix additions

ASecondGuy added 15 commits June 29, 2022 11:27

Merge pull request #4 from b7g/next-level-visual

85587ef

Merge Next level visual

menu scene tree refactor game page

521dbc8

menu scene tree refactor about page

5b1175b

menu scene tree refactor settings page

97fcb5c

fix scroll to bug report

f13a63d

Merge branch 'next-level-visual' of https://github.com/b7g/Suffragium …

1b2eb5f

…into b7g-next-level-visual # Conflicts: # game/app/scenes/menu.tscn

Fixing stuff the merge broke

aa71c1d

Merge pull request #6 from ASecondGuy/b7g-next-level-visual

046536a

Merge B7g next level visual

Fix title font and added margin container to main_theme.tres

f25d0ab

fix about page crashing on reload

d97e7eb

game_card scene tree refactor

113310c

game_card_add_yours scene tree refactor

9743b3b

fix assert fail

5d249f1

fix themes and theme overwrites

bf07df0

Merge branch 'next-level-visual' into next-level-visual-fix

d0f86f1

fix merge

e543383

ASecondGuy added 2 commits June 30, 2022 20:09

rename About.gd to about.gd

e18028b

fix about page empty bottom part

a737e8b

RedstoneMedia and others added 2 commits June 30, 2022 22:51

Fixed most colors/margins

98e9722

fix visuals

957df31

fix visuals again

22f049f

refactor about.gd thanks to Numenters tip

3bcfb9c

Fixed play time game card position

0bb36f7

fix more visuals

b2562a0

RedstoneMedia and others added 2 commits July 2, 2022 18:34

Merge branch 'next-level-visual-fix' of https://github.com/ASecondGuy…

59a955f

…/Suffragium into asecondguy-next-level-visual-fix-fix

Merge pull request #8 from RedstoneMedia/asecondguy-next-level-visual…

14bed83

…-fix-fix Fixed play time game card position

b7g merged commit 8e271ad into b7g:next-level-visual Jul 2, 2022

b7g added a commit that referenced this pull request Jul 2, 2022

Revert "mainly scene restructurdicting Next level visual fix (#6)"

7975edf

This reverts commit 8e271ad.

ASecondGuy deleted the next-level-visual-fix branch July 4, 2022 12:15

b7g pushed a commit that referenced this pull request Jan 29, 2023

Merge pull request #6 from RedstoneMedia/sortit-buggy-physics-godot3.…

0bbc599

…5-additions Sort It physics godot3.5 fix additions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Next level visual fix #6

Next level visual fix #6

ASecondGuy commented Jun 30, 2022 •

edited

Loading

ASecondGuy commented Jun 30, 2022 •

edited

Loading

ASecondGuy commented Jun 30, 2022

ASecondGuy commented Jun 30, 2022

RedstoneMedia commented Jun 30, 2022 •

edited

Loading

ASecondGuy commented Jun 30, 2022

ASecondGuy commented Jun 30, 2022

ASecondGuy commented Jul 1, 2022

RedstoneMedia commented Jul 1, 2022 •

edited

Loading

ASecondGuy commented Jul 1, 2022

b7g commented Jul 1, 2022

Numenter commented Jul 1, 2022

ASecondGuy commented Jul 1, 2022

RedstoneMedia commented Jul 1, 2022

Numenter commented Jul 1, 2022 •

edited

Loading

ASecondGuy commented Jul 2, 2022

b7g commented Jul 2, 2022 •

edited

Loading

RedstoneMedia commented Jul 2, 2022 •

edited

Loading

b7g commented Jul 2, 2022

RedstoneMedia commented Jul 2, 2022

ASecondGuy commented Jul 2, 2022

b7g commented Jul 2, 2022

ASecondGuy commented Jul 2, 2022

RedstoneMedia commented Jul 2, 2022 •

edited

Loading

b7g commented Jul 2, 2022

RedstoneMedia commented Jul 2, 2022

ASecondGuy commented Jul 2, 2022

b7g commented Jul 2, 2022

b7g commented Jul 2, 2022

RedstoneMedia commented Jul 2, 2022

ASecondGuy commented Jul 2, 2022

Next level visual fix #6

Next level visual fix #6

Conversation

ASecondGuy commented Jun 30, 2022 • edited Loading

Description

Type of change

Testing

Checklist

ASecondGuy commented Jun 30, 2022 • edited Loading

ASecondGuy commented Jun 30, 2022

ASecondGuy commented Jun 30, 2022

RedstoneMedia commented Jun 30, 2022 • edited Loading

ASecondGuy commented Jun 30, 2022

ASecondGuy commented Jun 30, 2022

ASecondGuy commented Jul 1, 2022

RedstoneMedia commented Jul 1, 2022 • edited Loading

ASecondGuy commented Jul 1, 2022

b7g commented Jul 1, 2022

Numenter commented Jul 1, 2022

ASecondGuy commented Jul 1, 2022

RedstoneMedia commented Jul 1, 2022

Numenter commented Jul 1, 2022 • edited Loading

ASecondGuy commented Jul 2, 2022

b7g commented Jul 2, 2022 • edited Loading

RedstoneMedia commented Jul 2, 2022 • edited Loading

b7g commented Jul 2, 2022

RedstoneMedia commented Jul 2, 2022

ASecondGuy commented Jul 2, 2022

b7g commented Jul 2, 2022

ASecondGuy commented Jul 2, 2022

RedstoneMedia commented Jul 2, 2022 • edited Loading

b7g commented Jul 2, 2022

RedstoneMedia commented Jul 2, 2022

ASecondGuy commented Jul 2, 2022

b7g commented Jul 2, 2022

b7g commented Jul 2, 2022

RedstoneMedia commented Jul 2, 2022

ASecondGuy commented Jul 2, 2022

ASecondGuy commented Jun 30, 2022 •

edited

Loading

ASecondGuy commented Jun 30, 2022 •

edited

Loading

RedstoneMedia commented Jun 30, 2022 •

edited

Loading

RedstoneMedia commented Jul 1, 2022 •

edited

Loading

Numenter commented Jul 1, 2022 •

edited

Loading

b7g commented Jul 2, 2022 •

edited

Loading

RedstoneMedia commented Jul 2, 2022 •

edited

Loading

RedstoneMedia commented Jul 2, 2022 •

edited

Loading