fix: Cannot polyfilled on optional chains #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
approved these changes
Sep 19, 2024
|
@liuxingbaoyu @JLHwung I added a commit to also support |
packages/babel-plugin-polyfill-corejs3/test/fixtures/usage-pure/optional-chaining/output.mjs
Outdated
Show resolved
Hide resolved
|
Hold on, there are a few more bugs. |
|
Ok, it should be good now :) |
nicolo-ribaudo
force-pushed
the
fix-OptionalMemberExpression
branch
from
c5aa462 to
f2676a8
Compare
liuxingbaoyu
commented
Sep 20, 2024
| ((_context14 = a.b) == null ? void 0 : _toSortedInstanceProperty(_context14.c))?.d.e; | ||
| _Array$from(x); | ||
| _Array$from?.(x); | ||
| _Array$from?.(x).c; |
There was a problem hiding this comment.
Non-blocking: Maybe we can compile to _Array$from(x)?
JLHwung
approved these changes
Sep 20, 2024
|
Would it be possible to get a publish of this package to get the fix out into the world? |
|
Yes :) |
|
Thank you so much and for all the previous work on this as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: babel/babel#16845