fix: change order of merging configs #33
Merged
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: djamaile <rdjamaile@gmail.com>
mitchhentgesspotify
approved these changes
Jan 10, 2024
Contributor
mitchhentgesspotify
left a comment
mitchhentgesspotify
left a comment
There was a problem hiding this comment.
This seems purely style and like a no-op, I'm surprised that it's changing behaviour - isn't the callback the first parameter either way? Weird.
Comment on lines
188
to
189
| const CONTAINER_SERVICE_URL = containerService.url.apply(url => | ||
| url.endsWith('/') ? url.slice(0, -1) : url | ||
| url.endsWith('/') ? url.slice(0, -1) : url, |
Contributor
There was a problem hiding this comment.
While you're here, do you mind making CONTAINER_SERVICE_URL -> containerServiceUrl? I didn't want to bother a contributor with this nit, but I'm happy to bug you with it 😉
Signed-off-by: djamaile <rdjamaile@gmail.com>
mitchhentgesspotify
approved these changes
Jan 10, 2024
| RUN echo " generator:" >> app-config.deployment.yaml | ||
| RUN echo " runIn: 'local'" >> app-config.deployment.yaml | ||
|
|
||
| CMD ["node", "packages/backend", "--config", "app-config.deployment.yaml", "--config", "app-config.yaml"] |
Contributor
There was a problem hiding this comment.
What in tarnation is the change here? Weird why this is showing up in the diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baseUrl doesn't get replaced:
❯ yarn backstage-cli config:print --config app-config.deployment.yaml --config app-config.yaml --frontend yarn run v1.22.19 $ /Users/djamailer/Desktop/projects/backstage-changeset/node_modules/.bin/backstage-cli config:print --config app-config.deployment.yaml --config app-config.yaml --frontend Loaded config from app-config.deployment.yaml, app-config.yaml app: baseUrl: http://localhost:3000 title: Scaffolded Backstage App backend: baseUrl: http://localhost:7007 organization: name: My Company integrations: github: - host: github.com techdocs: builder: local catalog: import: entityFilename: catalog-info.yaml pullRequestBranchName: backstage-integration ✨ Done in 1.02s.baseUrl gets properly replaced:
❯ yarn backstage-cli config:print --config app-config.yaml --config app-config.deployment.yaml --frontend yarn run v1.22.19 $ /Users/djamailer/Desktop/projects/backstage-changeset/node_modules/.bin/backstage-cli config:print --config app-config.yaml --config app-config.deployment.yaml --frontend Loaded config from app-config.yaml, app-config.deployment.yaml app: title: Scaffolded Backstage App baseUrl: http://test organization: name: My Company backend: baseUrl: http://test integrations: github: - host: github.com techdocs: builder: local catalog: import: entityFilename: catalog-info.yaml pullRequestBranchName: backstage-integration ✨ Done in 1.22s.