auth-backend: migrate GitHub provider #19473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
|
Uffizzi Preview |
19 tasks
jhaals
reviewed
Aug 21, 2023
| @@ -0,0 +1,8 @@ | |||
| # Auth Module: GitHub Provider | |||
|
|
|||
| This module provides an GitHub auth provider implementation for `@backstage/plugin-auth-backend`. | |||
There was a problem hiding this comment.
Is there some docs that should be added or updated to direct people to this module?
There was a problem hiding this comment.
Eventually we'll want to add it to the backend system migration docs and once we switch to the new system, the auth docs
| @@ -384,6 +384,8 @@ export interface OAuthSession { | |||
| // (undocumented) | |||
| refreshToken?: string; | |||
| // (undocumented) | |||
| refreshTokenExpiresInSeconds?: number; | |||
There was a problem hiding this comment.
changeset to release this package or has it already gone out with the other PR?
There was a problem hiding this comment.
Ah, yeah the OAuthSession interface hasn't been released yet.
jhaals
approved these changes
Aug 22, 2023
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This migrates the GitHub provider to be a separate module. It also adds the optional
refreshTokenExpiresInSecondsfield to theOAuthSessioninterface.✔️ Checklist
Signed-off-byline in the message. (more info)