-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: experimentally support using rspack instead #25953
Conversation
Changed Packages
|
c2b4930
to
87e34dc
Compare
Not for sure how to fix the typings issue. See also web-infra-dev/rspack#7511 |
close backstage#21682 Signed-off-by: JounQin <admin@1stg.me>
Signed-off-by: JounQin <admin@1stg.me>
Signed-off-by: JounQin <admin@1stg.me>
Signed-off-by: JounQin <admin@1stg.me>
Signed-off-by: JounQin <admin@1stg.me>
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
ping |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for letting this one sit, had another look now and thinking that with these comments resolved we'd be ready to merge
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the suggested changes out of the way and resolved conflicts, ready to ship for the next release
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: JounQin <admin@1stg.me>
I've just upgraded rspack to v1.0 |
@JounQin thank you! Gonna |
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
close #21682
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-by
line in the message. (more info)