Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimentally support using rspack instead #25953

Merged
merged 11 commits into from
Oct 12, 2024

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Aug 8, 2024

close #21682

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@JounQin JounQin requested review from backstage-service and a team as code owners August 8, 2024 17:08
@JounQin JounQin requested review from freben and camilaibs August 8, 2024 17:08
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Aug 8, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/cli packages/cli patch v0.28.0-next.2

@JounQin
Copy link
Contributor Author

JounQin commented Aug 9, 2024

Not for sure how to fix the typings issue. See also web-infra-dev/rspack#7511

close backstage#21682

Signed-off-by: JounQin <admin@1stg.me>
Signed-off-by: JounQin <admin@1stg.me>
Signed-off-by: JounQin <admin@1stg.me>
Signed-off-by: JounQin <admin@1stg.me>
Signed-off-by: JounQin <admin@1stg.me>
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Aug 28, 2024
@JounQin
Copy link
Contributor Author

JounQin commented Aug 28, 2024

ping

@github-actions github-actions bot removed the stale label Aug 28, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Sep 20, 2024
@JounQin
Copy link
Contributor Author

JounQin commented Sep 23, 2024

ping

@github-actions github-actions bot removed the stale label Sep 23, 2024
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for letting this one sit, had another look now and thinking that with these comments resolved we'd be ready to merge

packages/cli/src/lib/bundler/config.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/bundler/config.ts Outdated Show resolved Hide resolved
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the suggested changes out of the way and resolved conflicts, ready to ship for the next release :shipit:

Rugvip and others added 3 commits October 11, 2024 10:05
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: JounQin <admin@1stg.me>
@JounQin
Copy link
Contributor Author

JounQin commented Oct 12, 2024

I've just upgraded rspack to v1.0

@Rugvip
Copy link
Member

Rugvip commented Oct 12, 2024

@JounQin thank you! Gonna :shipit:

@Rugvip Rugvip merged commit a45e483 into backstage:master Oct 12, 2024
29 checks passed
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.32.0 release, scheduled for Tue, 15 Oct 2024.

@Rugvip Rugvip mentioned this pull request Oct 15, 2024
@JounQin JounQin deleted the feat/rspack branch October 22, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: migrate from webpack to rspack
2 participants