-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backstage
field to export in package.json
#26524
Conversation
Changed Packages
|
Thanks for the contribution! |
77668c4
to
5807f75
Compare
exports
field to Backstage metadata in package.json features
field to Backstage metadata in package.json
fc48e17
to
397ab03
Compare
35e21b8
to
c6cb2d1
Compare
Added a fixer step to the backstage-cli fix command that will annotate default export features to the package json backstage metadata Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
c6cb2d1
to
fd8128c
Compare
features
field to Backstage metadata in package.json backstage
field to export in package.json
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I think we're about ready to ship 😎
Just a couple of minor bits
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
e97b771
to
0b2794a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, let's ! 👍
Love how slim we ended up getting this in the end 🎉
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
This adds a step to the prepack command that will add an additional "backstage" metadata field to
exports
which provides information on the default export of the Backstage package.The way it extracts the information is to use ts-morph which works the same way as the typescript server does for IDEs and uses the compiler to build up references and resolves types so we can avoid having to traverse the AST to look for type information.