-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing config.d.ts values #26960
Conversation
Closes: #26958 Signed-off-by: Jente Sondervorst <jentesondervorst@gmail.com>
Changed Packages
|
@mclarke47 do you have a min to look through these changes? |
@benjdlambert would you have some idea on some other reviewer for this? |
Signed-off-by: Jente Sondervorst <jentesondervorst@gmail.com>
@aramissennyeydd would you know someone who can do an approving review of this very small PR? |
@Jenson3210 @mclarke47 is the right person to review this - reviews may be a bit slow. Left a message in Discord about a possible way to unblock you for the time being until this can go in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took it upon myself to double check these and I think it does mirror the code as far as I can tell. Going for a merge-and-ask-for-forgiveness-later on this one. 🙏
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Hey, I just made a Pull Request!
Adapted the config.d.ts values in order to close: #26958
✔️ Checklist
Signed-off-by
line in the message. (more info)