Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing config.d.ts values #26960

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

Jenson3210
Copy link
Contributor

Hey, I just made a Pull Request!

Adapted the config.d.ts values in order to close: #26958

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • All your commits have a Signed-off-by line in the message. (more info)

Closes: #26958
Signed-off-by: Jente Sondervorst <jentesondervorst@gmail.com>
@Jenson3210 Jenson3210 requested a review from a team as a code owner October 3, 2024 22:18
@github-actions github-actions bot added the area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. label Oct 3, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Oct 3, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-kubernetes-backend plugins/kubernetes-backend patch v0.18.8-next.0

@benjdlambert
Copy link
Member

@mclarke47 do you have a min to look through these changes?

@Jenson3210
Copy link
Contributor Author

@benjdlambert would you have some idea on some other reviewer for this?
Or maybe @mclarke47 missed the first request?

Signed-off-by: Jente Sondervorst <jentesondervorst@gmail.com>
@Jenson3210
Copy link
Contributor Author

@aramissennyeydd would you know someone who can do an approving review of this very small PR?
Or would you have an idea on how I can get this part published locally so I can at least continue with our setup?
Don't mean to pressurize :/

@aramissennyeydd
Copy link
Contributor

@Jenson3210 @mclarke47 is the right person to review this - reviews may be a bit slow. Left a message in Discord about a possible way to unblock you for the time being until this can go in.

@freben freben self-requested a review October 31, 2024 06:31
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it upon myself to double check these and I think it does mirror the code as far as I can tell. Going for a merge-and-ask-for-forgiveness-later on this one. 🙏

@freben freben merged commit 69696f9 into backstage:master Nov 5, 2024
24 checks passed
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.33.0 release, scheduled for Tue, 19 Nov 2024.

@Jenson3210 Jenson3210 deleted the issue_26958 branch November 7, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Config validation does not allow for custom k8s authProvider
4 participants