-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins/scaffolder-backend): add new fs:readdir action #27283
feat(plugins/scaffolder-backend): add new fs:readdir action #27283
Conversation
Changed Packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although the distinction between files and folders may be a little bit arbitrary - by which I mean, could have been a flat list with type fields just as well. So it's made this way to solve a certain use case of course. Could also have had an input argument that selects what types of thing you are looking for, I guess; matter of taste. WDYT @benjdlambert ?
My thought has been, to allow easier access for users for common cases as filtering can be a pain with Nunjucks. That being said I'm open to create a third generic |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Still valid |
Signed-off-by: secustor <sebastian@poxhofer.at>
Signed-off-by: secustor <sebastian@poxhofer.at>
57c2e88
to
2dae341
Compare
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Hey, I just made a Pull Request!
Adds a new action (
fs:readdir
) which allows to retrieve the current content of the workspace.In my current use case I need this to create on PR per folder in the workspace, though there are a lot of other use cases e.g. output texts
✔️ Checklist
Signed-off-by
line in the message. (more info)