Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins/scaffolder-backend): add new fs:readdir action #27283

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

secustor
Copy link
Member

Hey, I just made a Pull Request!

Adds a new action ( fs:readdir ) which allows to retrieve the current content of the workspace.

In my current use case I need this to create on PR per folder in the workspace, though there are a lot of other use cases e.g. output texts

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@secustor secustor requested review from a team as code owners October 21, 2024 17:04
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label Oct 21, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Oct 21, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-scaffolder-backend plugins/scaffolder-backend patch v1.27.0-next.2

Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although the distinction between files and folders may be a little bit arbitrary - by which I mean, could have been a flat list with type fields just as well. So it's made this way to solve a certain use case of course. Could also have had an input argument that selects what types of thing you are looking for, I guess; matter of taste. WDYT @benjdlambert ?

@secustor
Copy link
Member Author

My thought has been, to allow easier access for users for common cases as filtering can be a pain with Nunjucks.

That being said I'm open to create a third generic elements or dirent output, which contains the other two outputs combined.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Nov 5, 2024
@secustor
Copy link
Member Author

secustor commented Nov 5, 2024

Still valid

@github-actions github-actions bot removed the stale label Nov 5, 2024
Signed-off-by: secustor <sebastian@poxhofer.at>
Signed-off-by: secustor <sebastian@poxhofer.at>
@benjdlambert benjdlambert force-pushed the feat/add-new-readdir-action branch from 57c2e88 to 2dae341 Compare November 8, 2024 15:22
@benjdlambert benjdlambert merged commit dff1a55 into backstage:master Nov 8, 2024
23 checks passed
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.33.0 release, scheduled for Tue, 19 Nov 2024.

@secustor secustor deleted the feat/add-new-readdir-action branch November 8, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants