repo-tools: add generate-patch command #27331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
github-actions
bot
added
the
area:documentation
Changed Packages
|
Co-authored-by: Ben Lambert <blam@spotify.com> Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Rugvip
force-pushed
the
rugvip/genpatch
branch
from
709a054 to
59f40dc
Compare
freben
approved these changes
Oct 24, 2024
packages/repo-tools/src/commands/generate-patch/generate-patch.ts
Outdated
Show resolved
Hide resolved
packages/repo-tools/src/commands/generate-patch/generate-patch.ts
Outdated
Show resolved
Hide resolved
packages/repo-tools/src/commands/generate-patch/generate-patch.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Fredrik Adelöw <freben@gmail.com> Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This adds a new
generate-patchcommand to@backstage/repo-tools. The purpose of it is to simplify the process of contributing changes to an external repo, but then also use those changes immediately. It automates the process of running building the package, packing it to a folder, applying those changes to a directory created withyarn patch, and then applying that patch and removing the old ones. The automated process is slightly different than than in that it uses a downloaded version of the package as the base, but it ends up being effectively the same thing - you bring the current code in one project into another.I chose to nudge the behavior of this in the direction of including all changes to the package in the source workspace, rather than cherry-picking individual changes. The idea is that this makes it simpler to manage multiple patched changes at once, since you end up with all the current changes to the package. It's of course possible to create a new branch based on the previous release and cherry-pick only the desired changes though.
✔️ Checklist
Signed-off-byline in the message. (more info)