Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Google LDAP Vendor #27373

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

megatroom
Copy link
Contributor

@megatroom megatroom commented Oct 25, 2024

This PR introduces support for Google as a new LDAP vendor within the @backstage/plugin-catalog-backend-module-ldap. The change enables proper mapping and association between users and groups retrieved from Google's LDAP service.

Resolves #27323

Key Change: extended the existing LDAP integration to support Google's specific schema, ensuring correct user group associations are reflected in the Backstage catalog.

This enhancement will allow Backstage users working with Google LDAP to seamlessly synchronize their organization's user and group data.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@megatroom megatroom requested review from a team as code owners October 25, 2024 22:00
@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label Oct 25, 2024
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-backend-module-ldap plugins/catalog-backend-module-ldap minor v0.9.2-next.0

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

Signed-off-by: Bruno Nardini <bruno.nardini@mercafacil.com>
Signed-off-by: Bruno Nardini <bruno.nardini@mercafacil.com>
Copy link
Contributor

@camilaibs camilaibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks again.

@camilaibs
Copy link
Contributor

@benjdlambert could you please take a look when you have a moment 🙂 ?

Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 👍

@Rugvip Rugvip merged commit afa24b3 into backstage:master Nov 5, 2024
23 checks passed
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.33.0 release, scheduled for Tue, 19 Nov 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:catalog Related to the Catalog Project Area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Implement Google LDAP service support
3 participants