Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure EntityDisplayName component link receives underline on hover #27552

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Ensure EntityDisplayName component link receives underline on hover #27552

merged 1 commit into from
Nov 12, 2024

Conversation

jroebu14
Copy link
Contributor

@jroebu14 jroebu14 commented Nov 7, 2024 •
edited
Loading

Hey, I just made a Pull Request!

Ensure EntityDisplayName component link receives underline on hover.

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label Nov 7, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 7, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-react plugins/catalog-react patch v1.14.1-next.2

@jroebu14 jroebu14 marked this pull request as ready for review November 7, 2024 13:56
@jroebu14 jroebu14 requested review from a team as code owners November 7, 2024 13:56
@jroebu14
Ensure EntityDisplayName component link receives underline on hover
6fcbb3b 
Signed-off-by: Jonathan Roebuck <jroebuck@spotify.com>
jhaals
jhaals approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jhaals jhaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@jhaals jhaals merged commit b4e81c7 into master Nov 12, 2024
24 checks passed
@jhaals jhaals deleted the fix-missing-link-underline branch November 12, 2024 10:58
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.33.0 release, scheduled for Tue, 19 Nov 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhaals jhaals jhaals approved these changes

@camilaibs camilaibs Awaiting requested review from camilaibs camilaibs is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jroebu14 @jhaals