Enable customization of CatalogTable pagination #27558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Davis <tylerd@canva.com>
Signed-off-by: Tyler Davis <tylerd@canva.com>
Changed Packages
|
tylerd-canva
commented
Nov 8, 2024
| @@ -39,9 +39,9 @@ export function CursorPaginatedCatalogTable(props: PaginatedCatalogTableProps) { | |||
| columns={columns} | |||
| data={data} | |||
| options={{ | |||
| paginationPosition: 'both', | |||
| ...options, | |||
There was a problem hiding this comment.
I think it makes more sense to put this at the bottom of the list so that all of them can be overridden, but it seemed like it was intentional based on the comment below this line.
There was a problem hiding this comment.
yep, correct. But your change makes sense to me!
vinzscam
reviewed
Nov 8, 2024
| @@ -39,9 +39,9 @@ export function CursorPaginatedCatalogTable(props: PaginatedCatalogTableProps) { | |||
| columns={columns} | |||
| data={data} | |||
| options={{ | |||
| paginationPosition: 'both', | |||
| ...options, | |||
There was a problem hiding this comment.
yep, correct. But your change makes sense to me!
Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com> Signed-off-by: Tyler Davis <tylerd@canva.com>
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
I was looking to make use of one of the server side paginated CatalogTables but realised neither of them allowed you to remove the awful (IMHO) top pagination buttons. For
CursorPaginatedCatalogTableI left the...optionsat the conservative spot above the other pagination options since it seemed deliberate to not allow overriding them.✔️ Checklist
Signed-off-byline in the message. (more info)