-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contextMenu prop to Actions and ListTasks #27565
Merged
benjdlambert
merged 7 commits into
backstage:master
from
jescalada:scaffolder-page-contextmenu-props-bugfix
Nov 12, 2024
Merged
Add contextMenu prop to Actions and ListTasks #27565
benjdlambert
merged 7 commits into
backstage:master
from
jescalada:scaffolder-page-contextmenu-props-bugfix
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
github-actions
bot
added
the
area:scaffolder
Everything and all things related to the scaffolder project area
label
Nov 9, 2024
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Changed Packages
|
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
2 tasks
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
Signed-off-by: blam <ben@blam.sh>
benjdlambert
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice thanks for the fix here! 🎉
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Related: #27448
Changelog
contextMenu
prop to scaffolder plugin'sActionsPage
andListTasksPage
{ editor: false }
as thecontextMenu
prop, where the/create/*
routes don't remove the editor linkPlease let me know if adding/modifying tests is required for this PR!
Note: I edited a line in
ScaffolderPageContextMenu
which used to check that either the editor OR the actions callbacks were present. If not, the context menu would not render. I'm not sure about the purpose of this line, but adding additional checks for the other callbacks is required to render the context menu on/create/actions/
when{ editor: false }
is set.Screenshots
When
{ editor: false }
is passed to theScaffolderPage
contextMenu
prop:/create
/create/actions
/create/tasks
✔️ Checklist
Signed-off-by
line in the message. (more info)