Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contextMenu prop to Actions and ListTasks #27565

Conversation

jescalada
Copy link
Contributor

@jescalada jescalada commented Nov 9, 2024

Hey, I just made a Pull Request!

Related: #27448

Changelog

  • Added contextMenu prop to scaffolder plugin's ActionsPage and ListTasksPage
    • Fixes issue when passing { editor: false } as the contextMenu prop, where the /create/* routes don't remove the editor link

Please let me know if adding/modifying tests is required for this PR!

Note: I edited a line in ScaffolderPageContextMenu which used to check that either the editor OR the actions callbacks were present. If not, the context menu would not render. I'm not sure about the purpose of this line, but adding additional checks for the other callbacks is required to render the context menu on /create/actions/ when { editor: false } is set.

Screenshots

When { editor: false } is passed to the ScaffolderPage contextMenu prop:

/create

image

/create/actions

image

/create/tasks

image

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
@jescalada jescalada requested review from a team as code owners November 9, 2024 05:13
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label Nov 9, 2024
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 9, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-scaffolder-react plugins/scaffolder-react minor v1.13.3-next.2
@backstage/plugin-scaffolder plugins/scaffolder minor v1.26.3-next.2

Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
jescalada and others added 2 commits November 9, 2024 16:12
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
Signed-off-by: blam <ben@blam.sh>
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks for the fix here! 🎉

@benjdlambert benjdlambert merged commit d44322a into backstage:master Nov 12, 2024
24 checks passed
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.33.0 release, scheduled for Tue, 19 Nov 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants