Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notifications): show count of unread notifications in the left-side MenuItem #27567

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feat(notifications): show count of unread notifications in the left-side MenuItem #27567

merged 1 commit into from
Nov 19, 2024

Conversation

mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Nov 9, 2024 •
edited
Loading

Hey, I just made a Pull Request!

The Notifications' left-side MenuItem shows the count of unread messages instead of just a simple bullet.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@mareklibra
feat(notifications): show count of unread notifications in the left-s…
1d87c43 
…ide MenuItem

Signed-off-by: Marek Libra <marek.libra@gmail.com>
@mareklibra mareklibra requested review from a team as code owners November 9, 2024 17:41
@mareklibra
Copy link
Contributor Author

light normal

With limit:

light limit99

No unread:

light none

@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-notifications plugins/notifications patch v0.3.3-next.1

@freben freben merged commit bc33ee6 into backstage:master Nov 19, 2024
22 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.33.0 release, scheduled for Tue, 19 Nov 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rugvip Rugvip Rugvip approved these changes

@freben freben Awaiting requested review from freben freben is a code owner automatically assigned from backstage/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mareklibra @Rugvip @freben