feat(notifications): add title to the Notifications' table #27568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
|
|
mareklibra
force-pushed
the
FLPATH-1841.showTotalInTitle
branch
from
5f48a03
to
6a6c0c7
Compare
jhaals
requested changes
Nov 12, 2024
.changeset/khaki-pugs-perform.md
Outdated
| '@backstage/plugin-notifications': minor | ||
| --- | ||
|
|
||
| Added title to the Notifications' table. The title clearly states the filter selectino and total count of messages. This change aligns the look and fel closer to other tables. |
There was a problem hiding this comment.
Suggested change
| Added title to the Notifications' table. The title clearly states the filter selectino and total count of messages. This change aligns the look and fel closer to other tables. | |
| Added title to the Notifications' table. The title clearly states the filter selectin and total count of messages. This change aligns the look and feel closer to other tables. |
.changeset/khaki-pugs-perform.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@backstage/plugin-notifications': minor | |||
There was a problem hiding this comment.
Suggested change
| '@backstage/plugin-notifications': minor | |
| '@backstage/plugin-notifications': patch |
Package is below 1.x so a patch changeset is enough for introducing new non breaking features.
Signed-off-by: Marek Libra <marek.libra@gmail.com>
mareklibra
force-pushed
the
FLPATH-1841.showTotalInTitle
branch
from
6a6c0c7
to
4186105
Compare
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Notifications' table has newly a title with count of filtered records.
✔️ Checklist
Signed-off-byline in the message. (more info)