feat(notifications): emphasize notification's title #27569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First attempt, use
|
Changed Packages
|
Rugvip
reviewed
Nov 12, 2024
| ) : ( | ||
| notification.payload.title | ||
| )} | ||
| <Box sx={{ fontWeight: 'bold' }}> |
There was a problem hiding this comment.
is there a Typography variant that you can use instead? thinking h5 or h6 might fit
There was a problem hiding this comment.
Those h5 or h6 are still too big, distracting.
Trying subtitle1. Please see the later screenshot. Wdyt?
Signed-off-by: Marek Libra <marek.libra@gmail.com>
mareklibra
force-pushed
the
FLPATH-1840.emphasizeNotificationTitle
branch
from
9482ebc
to
3e135f2
Compare
|
Trying typography with
|
benjdlambert
approved these changes
Nov 15, 2024
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
The notification's title is emphasized to be clearly distinguished from the description.
✔️ Checklist
Signed-off-byline in the message. (more info)